Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CRASH, Regression] In face/on-change* (stack corruption?) #4543

Closed
hiiamboris opened this issue Jun 24, 2020 · 0 comments
Closed

[CRASH, Regression] In face/on-change* (stack corruption?) #4543

hiiamboris opened this issue Jun 24, 2020 · 0 comments
Assignees
Labels
status.built A change in codebase has been done to address the ticket. status.tested The change in code has been manually tested and verified to fix the issue. type.bug Ticket describes an abnormal behavior, not conforming to the specs or expectation.
Milestone

Comments

@hiiamboris
Copy link
Collaborator

hiiamboris commented Jun 24, 2020

Describe the bug

Console builds before May 28, 2020 do not crash. Since June 8, 2020 they do (CLI/GUI both)

This snippet lists variants that crash and that don't:

Red [needs: view]

extend system/view/VID/styles [
	crash: [
		template: [
			type: 'base
			size: 100x100
			; on-change*: function probe spec-of :face!/on-change* [if a: none []]	;) CRASH
			; on-change*: func     probe spec-of :face!/on-change* [if a: none []]	;) OK
			; on-change*: function [w o n /local b c d e]   [if a: none []]			;) CRASH
			; on-change*: func     [w o n /local b c d e a] [if a: none []]			;) CRASH
			; on-change*: func     [w o n /local a b c d e] [if a: none []]			;) OK
			on-change*: func     [w o n /local a b c d e] [if e: none []]			;) CRASH
		]
	]
]
view [crash]

Results in:

--------- `red-latest`
*** Runtime Error 1: access violation
*** at: 00000000h                    
--------- `-d console`
*** Runtime Error 1: access violation
*** in file: �+                      
*** at line: 1818845542              
***
--------- `another -d console`
*** Runtime Error 1: access violation
*** in file: ½0                      
*** at line: 1818845542              
***                                  
(and so on)

Changing a: none to a: 1 or smth changes the address from 0 to e.g. 0203h. Remove if and no crash. If assigned word is not at the spec tail - no crash. Less than five locals - also no crash.

Expected behavior

Base shown.

Platform version (please complete the following information)

Red 0.6.4 for Windows built 20-Jun-2020/20:24:25+03:00 commit #4d864b1
@hiiamboris hiiamboris changed the title [CRASH] In face/on-change* (stack corruption?) [CRASH, Regression] In face/on-change* (stack corruption?) Jul 24, 2020
@dockimbel dockimbel self-assigned this Aug 25, 2022
@dockimbel dockimbel added status.impending Ticket is under processing or will be processed very soon. type.bug Ticket describes an abnormal behavior, not conforming to the specs or expectation. labels Aug 26, 2022
dockimbel added a commit that referenced this issue Aug 26, 2022
#3804: [Core] object on-change* looks away most of the time
#3805: [CRASH/ERROR] when reactor!/on-change* is overridden
#4543: [CRASH, Regression] In face/on-change* (stack corruption?)
#4552: crash on probing context of SELF
#5135: SELF is not reactive
@dockimbel dockimbel added status.built A change in codebase has been done to address the ticket. status.tested The change in code has been manually tested and verified to fix the issue. and removed status.impending Ticket is under processing or will be processed very soon. labels Aug 26, 2022
@dockimbel dockimbel added this to the 0.7.0 milestone Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status.built A change in codebase has been done to address the ticket. status.tested The change in code has been manually tested and verified to fix the issue. type.bug Ticket describes an abnormal behavior, not conforming to the specs or expectation.
Projects
None yet
Development

No branches or pull requests

2 participants