Screenshots im Debug-Mode (#4863)

redaxo · Oct 30, 2021 · e6e3d77 · e6e3d77
1 parent 0b9641e
commit e6e3d77
Show file tree

Hide file tree

Showing 82 changed files with 15 additions and 5 deletions.
diff --git a/.github/tests-visual/backup_export--dark.png b/.github/tests-visual/backup_export--dark.png
diff --git a/.github/tests-visual/backup_export.png b/.github/tests-visual/backup_export.png
diff --git a/.github/tests-visual/backup_import--dark.png b/.github/tests-visual/backup_import--dark.png
diff --git a/.github/tests-visual/backup_import.png b/.github/tests-visual/backup_import.png
diff --git a/.github/tests-visual/backup_import_server--dark.png b/.github/tests-visual/backup_import_server--dark.png
diff --git a/.github/tests-visual/backup_import_server.png b/.github/tests-visual/backup_import_server.png
diff --git a/.github/tests-visual/cronjob_cronjobs--dark.png b/.github/tests-visual/cronjob_cronjobs--dark.png
diff --git a/.github/tests-visual/cronjob_cronjobs.png b/.github/tests-visual/cronjob_cronjobs.png
diff --git a/.github/tests-visual/cronjob_cronjobs_add--dark.png b/.github/tests-visual/cronjob_cronjobs_add--dark.png
diff --git a/.github/tests-visual/cronjob_cronjobs_add.png b/.github/tests-visual/cronjob_cronjobs_add.png
diff --git a/.github/tests-visual/index--dark.png b/.github/tests-visual/index--dark.png
diff --git a/.github/tests-visual/index.png b/.github/tests-visual/index.png
diff --git a/.github/tests-visual/media_manager_settings--dark.png b/.github/tests-visual/media_manager_settings--dark.png
diff --git a/.github/tests-visual/media_manager_settings.png b/.github/tests-visual/media_manager_settings.png
diff --git a/.github/tests-visual/media_manager_types--dark.png b/.github/tests-visual/media_manager_types--dark.png
diff --git a/.github/tests-visual/media_manager_types.png b/.github/tests-visual/media_manager_types.png
diff --git a/.github/tests-visual/media_manager_types_add--dark.png b/.github/tests-visual/media_manager_types_add--dark.png
diff --git a/.github/tests-visual/media_manager_types_add.png b/.github/tests-visual/media_manager_types_add.png
diff --git a/.github/tests-visual/media_manager_types_edit--dark.png b/.github/tests-visual/media_manager_types_edit--dark.png
diff --git a/.github/tests-visual/media_manager_types_edit.png b/.github/tests-visual/media_manager_types_edit.png
diff --git a/.github/tests-visual/metainfo_articles--dark.png b/.github/tests-visual/metainfo_articles--dark.png
diff --git a/.github/tests-visual/metainfo_articles.png b/.github/tests-visual/metainfo_articles.png
diff --git a/.github/tests-visual/metainfo_articles_add--dark.png b/.github/tests-visual/metainfo_articles_add--dark.png
diff --git a/.github/tests-visual/metainfo_articles_add.png b/.github/tests-visual/metainfo_articles_add.png
diff --git a/.github/tests-visual/metainfo_categories--dark.png b/.github/tests-visual/metainfo_categories--dark.png
diff --git a/.github/tests-visual/metainfo_categories.png b/.github/tests-visual/metainfo_categories.png
diff --git a/.github/tests-visual/metainfo_clangs--dark.png b/.github/tests-visual/metainfo_clangs--dark.png
diff --git a/.github/tests-visual/metainfo_clangs.png b/.github/tests-visual/metainfo_clangs.png
diff --git a/.github/tests-visual/metainfo_media--dark.png b/.github/tests-visual/metainfo_media--dark.png
diff --git a/.github/tests-visual/metainfo_media.png b/.github/tests-visual/metainfo_media.png
diff --git a/.github/tests-visual/modules_actions--dark.png b/.github/tests-visual/modules_actions--dark.png
diff --git a/.github/tests-visual/modules_actions.png b/.github/tests-visual/modules_actions.png
diff --git a/.github/tests-visual/modules_actions_add--dark.png b/.github/tests-visual/modules_actions_add--dark.png
diff --git a/.github/tests-visual/modules_actions_add.png b/.github/tests-visual/modules_actions_add.png
diff --git a/.github/tests-visual/modules_modules--dark.png b/.github/tests-visual/modules_modules--dark.png
diff --git a/.github/tests-visual/modules_modules.png b/.github/tests-visual/modules_modules.png
diff --git a/.github/tests-visual/modules_modules_add--dark.png b/.github/tests-visual/modules_modules_add--dark.png
diff --git a/.github/tests-visual/modules_modules_add.png b/.github/tests-visual/modules_modules_add.png
diff --git a/.github/tests-visual/packages--dark.png b/.github/tests-visual/packages--dark.png
diff --git a/.github/tests-visual/packages.png b/.github/tests-visual/packages.png
diff --git a/.github/tests-visual/packages_customizer_installed--dark.png b/.github/tests-visual/packages_customizer_installed--dark.png
diff --git a/.github/tests-visual/packages_customizer_installed.png b/.github/tests-visual/packages_customizer_installed.png
diff --git a/.github/tests-visual/packages_help--dark.png b/.github/tests-visual/packages_help--dark.png
diff --git a/.github/tests-visual/packages_help.png b/.github/tests-visual/packages_help.png
diff --git a/.github/tests-visual/phpmailer_config--dark.png b/.github/tests-visual/phpmailer_config--dark.png
diff --git a/.github/tests-visual/phpmailer_config.png b/.github/tests-visual/phpmailer_config.png
diff --git a/.github/tests-visual/structure_article_edit--dark.png b/.github/tests-visual/structure_article_edit--dark.png
diff --git a/.github/tests-visual/structure_article_edit.png b/.github/tests-visual/structure_article_edit.png
diff --git a/.github/tests-visual/structure_article_functions--dark.png b/.github/tests-visual/structure_article_functions--dark.png
diff --git a/.github/tests-visual/structure_article_functions.png b/.github/tests-visual/structure_article_functions.png
diff --git a/.github/tests-visual/structure_category_edit--dark.png b/.github/tests-visual/structure_category_edit--dark.png
diff --git a/.github/tests-visual/structure_category_edit.png b/.github/tests-visual/structure_category_edit.png
diff --git a/.github/tests-visual/structure_slice_edit--dark.png b/.github/tests-visual/structure_slice_edit--dark.png
diff --git a/.github/tests-visual/structure_slice_edit.png b/.github/tests-visual/structure_slice_edit.png
diff --git a/.github/tests-visual/system_customizer--dark.png b/.github/tests-visual/system_customizer--dark.png
diff --git a/.github/tests-visual/system_customizer.png b/.github/tests-visual/system_customizer.png
diff --git a/.github/tests-visual/system_lang--dark.png b/.github/tests-visual/system_lang--dark.png
diff --git a/.github/tests-visual/system_lang.png b/.github/tests-visual/system_lang.png
diff --git a/.github/tests-visual/system_log--dark.png b/.github/tests-visual/system_log--dark.png
diff --git a/.github/tests-visual/system_log.png b/.github/tests-visual/system_log.png
diff --git a/.github/tests-visual/system_report--dark.png b/.github/tests-visual/system_report--dark.png
diff --git a/.github/tests-visual/system_report.png b/.github/tests-visual/system_report.png
diff --git a/.github/tests-visual/system_settings--dark.png b/.github/tests-visual/system_settings--dark.png
diff --git a/.github/tests-visual/system_settings.png b/.github/tests-visual/system_settings.png
diff --git a/.github/tests-visual/system_settings_safemode--dark.png b/.github/tests-visual/system_settings_safemode--dark.png
diff --git a/.github/tests-visual/system_settings_safemode.png b/.github/tests-visual/system_settings_safemode.png
diff --git a/.github/tests-visual/templates--dark.png b/.github/tests-visual/templates--dark.png
diff --git a/.github/tests-visual/templates.png b/.github/tests-visual/templates.png
diff --git a/.github/tests-visual/templates_add--dark.png b/.github/tests-visual/templates_add--dark.png
diff --git a/.github/tests-visual/templates_add.png b/.github/tests-visual/templates_add.png
diff --git a/.github/tests-visual/templates_edit--dark.png b/.github/tests-visual/templates_edit--dark.png
diff --git a/.github/tests-visual/templates_edit.png b/.github/tests-visual/templates_edit.png
diff --git a/.github/tests-visual/users_edit--dark.png b/.github/tests-visual/users_edit--dark.png
diff --git a/.github/tests-visual/users_edit.png b/.github/tests-visual/users_edit.png
diff --git a/.github/tests-visual/users_role_add--dark.png b/.github/tests-visual/users_role_add--dark.png
diff --git a/.github/tests-visual/users_role_add.png b/.github/tests-visual/users_role_add.png
diff --git a/.github/tests-visual/users_roles--dark.png b/.github/tests-visual/users_roles--dark.png
diff --git a/.github/tests-visual/users_roles.png b/.github/tests-visual/users_roles.png
diff --git a/.github/tests-visual/users_users--dark.png b/.github/tests-visual/users_users--dark.png
diff --git a/.github/tests-visual/users_users.png b/.github/tests-visual/users_users.png
diff --git a/.github/tests-visual/visual-record.js b/.github/tests-visual/visual-record.js
@@ -123,8 +123,8 @@ function countDiffPixels(img1path, img2path ) {
 async function processScreenshot(page, screenshotName) {
     mkdirp.sync(WORKING_DIR);
 
-    // hide blinking cursor
-    await page.addStyleTag({ content: 'input { caret-color: transparent !important; }' });
+    // hide blinking cursor/icon
+    await page.addStyleTag({ content: 'input { caret-color: transparent !important; } * { animation: initial !important}' });
 
     // mask dynamic content, to make it not appear like change (visual noise)
     await page.evaluate(function() {
@@ -255,7 +255,7 @@ async function main() {
             for (var fileName in allPages) {
                 const url = allPages[fileName]
                 await goToUrlOrThrow(page, url, { waitUntil: 'load' });
-                
+
                 await page.waitForTimeout(350); // slight buffer for CSS animations or :focus styles etc.
                 await createScreenshots(page, fileName);
             }

diff --git a/.github/workflows/default.config.yml.github-action.diff b/.github/workflows/default.config.yml.github-action.diff
@@ -1,8 +1,18 @@
 diff --git a/redaxo/src/core/default.config.yml b/redaxo/src/core/default.config.yml
-index 8f1931d..d7b27f8 100644
+index 2880a09e9..7b45ccd4b 100644
 --- a/redaxo/src/core/default.config.yml
 +++ b/redaxo/src/core/default.config.yml
-@@ -63,9 +63,9 @@ table_prefix: rex_
+@@ -1,7 +1,7 @@
+ setup: true
+ debug:
+-    enabled: false
+-    throw_always_exception: false # `true` for all error levels, `[E_WARNING, E_NOTICE]` for subset
++    enabled: true
++    throw_always_exception: true # `true` for all error levels, `[E_WARNING, E_NOTICE]` for subset
+ instname: null
+ server: https://www.redaxo.org/
+ servername: REDAXO
+@@ -64,9 +64,9 @@ table_prefix: rex_
  temp_prefix: tmp_
  db:
      1: