Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Screenshots im Debug-Mode #4863

Merged
merged 5 commits into from Oct 30, 2021
Merged

Screenshots im Debug-Mode #4863

merged 5 commits into from Oct 30, 2021

Conversation

gharlan
Copy link
Member

@gharlan gharlan commented Oct 30, 2021

Damit auch bei Warnings/Notices abgebrochen wird.

Wir werden so jetzt auf allen Screenshots das Debug-Icon bekommen. Aber das macht eigentlich nix, oder?

Copy link
Member

@schuer schuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Co-authored-by: Marcel Kuhmann <marcel@dermarcel.eu>
Copy link
Member

@staabm staabm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like. Hast du es getestet?

Copy link
Member

@bloep bloep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@staabm
Copy link
Member

staabm commented Oct 30, 2021

Es wäre cool wenn wir den whoops screenshot committen aber trotzdem mit error abbrechen am ende. So würde man auch den fehler sehen

This reverts commit aa661c5.
@bloep
Copy link
Member

bloep commented Oct 30, 2021

Es wäre cool wenn wir den whoops screenshot committen aber trotzdem mit error abbrechen am ende. So würde man auch den fehler sehen

oder alternativ den stacktrace mit zum Error ausgeben

@gharlan gharlan added the automerge Automatisch PR rebasen und mergen label Oct 30, 2021
@kodiakhq kodiakhq bot merged commit e6e3d77 into main Oct 30, 2021
@kodiakhq kodiakhq bot deleted the screenshots-debug-mode branch October 30, 2021 11:34
@rex-bot rex-bot removed the automerge Automatisch PR rebasen und mergen label Oct 30, 2021
@staabm
Copy link
Member

staabm commented Oct 30, 2021

Der screenshot würde die komplette whoops page enthalten. Da hätte man viele infos auf einen blick

BenJ1337 pushed a commit to BenJ1337/redaxo that referenced this pull request Mar 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants