Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

debug() expanded design fix #5699

Merged
merged 2 commits into from
May 17, 2023
Merged

debug() expanded design fix #5699

merged 2 commits into from
May 17, 2023

Conversation

skerbis
Copy link
Contributor

@skerbis skerbis commented Apr 25, 2023

fügt den Fix #3628 wieder ein.

@tbaddade
Copy link
Member

Das passiert nur, wenn uikit verwendet wird? Sollte es dann nicht eher von uikit oder eigenem CSS jedoch nicht vom Core angepasst werden?

@gharlan
Copy link
Member

gharlan commented Apr 25, 2023

Ich denke, wir sollten schon versuchen, dass die dump-Ausgabe optisch möglichst immer passt, egal was für frameworks etc verwendet werden.

@skerbis
Copy link
Contributor Author

skerbis commented Apr 25, 2023

Alternativ sollten die Stile prefixed und vollständig resetet werden. Das epanded ist hier die einfachste Lösung. Samp ist kein so oft verwendeter tag. Bei Verwendung von uikit fiel es mir halt auf.

@gharlan gharlan added this to the REDAXO 5.15.2 milestone May 17, 2023
@gharlan gharlan changed the base branch from main to bugfix May 17, 2023 20:17
@gharlan gharlan force-pushed the skerbis-patch-css-fix-dump branch from a2a9967 to 6bb8249 Compare May 17, 2023 20:17
@gharlan gharlan added the automerge Automatisch PR rebasen und mergen label May 17, 2023
@kodiakhq kodiakhq bot merged commit f8ef62b into bugfix May 17, 2023
@kodiakhq kodiakhq bot deleted the skerbis-patch-css-fix-dump branch May 17, 2023 20:20
@rex-bot rex-bot removed the automerge Automatisch PR rebasen und mergen label May 17, 2023
@gharlan gharlan modified the milestones: REDAXO 5.15.2, REDAXO 5.16 Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants