Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding
react-native-config
to allow for the use of a.env
file to pass environment variables.There's a few options out there which do similar things. Once example is
react-native-dotenv
which simply inlines the environment variables using babel, but I couldn't get it, or similar projects to work.It seems like it's pretty much impossible to hide secrets from app bundles so the right way to do it is to call back to a server which handles any API key you are using. However I can't really see how that doesn't just make the problem worse because then you're opening up a public API anyone could use.
Either way, I think the variables we will be using aren't hugely sensitive. At least initially we will only be using the read-only contentful API key, which doesn't particularly matter if it leaks, and can be revoked if it starts to get spammed.
Anyone have thoughts?
Pre-flight check-list
Before raising a pull request
Unit testsPre-merge check-list
Tester approved