move to hugo #1
move to hugo #1
Conversation
|
@GoldenBadger @CSmartt @theycallmemac can I get some input on branding |
|
I have a document we've been using to explain what the event itself is to potential sponsors. I can send onto you soon. Some of the info in pages/About.md is dated, as is the location of the event on the homepage. I'll send on an updated document shortly. |
README.md
Outdated
|
|
||
| ``` | ||
| ### Docker | ||
| This repository contains the SISTEM website The website was written to have a |
There was a problem hiding this comment.
Nit: Missing fullstop.
README.md
Outdated
| Gulp concats this with materilize and minifies it to `dist/js` | ||
| ``` | ||
| git clone https://github.com/redbrick/sistem | ||
| cd sistem-site |
config.toml
Outdated
| sectionPagesMenu = "main" | ||
|
|
||
| [Params] | ||
| description = "a event ran by students, for students." |
There was a problem hiding this comment.
i just stole this from the about section ;)
content/live/_index.md
Outdated
| @@ -0,0 +1,3 @@ | |||
| --- | |||
| ltitle: "live" | |||
There was a problem hiding this comment.
ltitle -> title? How did this build?
There was a problem hiding this comment.
the templates all back to the site title
src/css/_card.scss
Outdated
| display: grid; | ||
| grid-gap: 1rem; // sass-lint:disable-line no-misspelled-properties | ||
| grid-template-columns: repeat(auto-fit, minmax(320px, 1fr)); | ||
| padding: 1rem; |
There was a problem hiding this comment.
I believe these magic numbers should be moved to variables in another file and imported. This for example should become std-padding or similar and reused.
There was a problem hiding this comment.
not a fan of std-padding as a concept as padding and margin can be quite content specific
| color: $green; | ||
| display: block; | ||
| margin: 0 1px 0 0; | ||
| padding: 10px 12px; |
There was a problem hiding this comment.
Mixing pixels and REMs? Should it not be consistent?
There was a problem hiding this comment.
/shrug
its a bit of a rush job and I'm eyeballing a few things more then happy for you to convert the later
|
if we just had a few images and the favicon id be happy to merge this |
|
just going to open issue for the images actually |
TODO