Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for X-B3-* trace headers. #187

Closed
cshoe opened this issue Jun 27, 2018 · 0 comments
Closed

Support for X-B3-* trace headers. #187

cshoe opened this issue Jun 27, 2018 · 0 comments

Comments

@cshoe
Copy link
Contributor

cshoe commented Jun 27, 2018

B3 propagation bas become the standard when using HTTP. Baseplate currently supports different headers for propagating trace data (Thrift ref, Pyramid/WSGI ref.

Supporting both the old version of headers and B3 shouldn't be too difficult.
cshoe added a commit to cshoe/baseplate that referenced this issue Jun 29, 2018
@cshoe
187 B3 Headers Support
a6358c2 
Add support for B3 trace headers whil continuing to support the old
trace headers. This change aims to allow both both B3 and the old
headers to be used as long as they contain identical values. For
example:

```
X-Trace: 1234567890abcdef
X-B3-TraceId: 1234567890abcdef
```

Change To Highlight

The old headers only allowed integer values for trace, span and parent
span ID fields. This change broadens that to 64 bit hex encoded strings.
Trace IDs can be either 64 or 128 bit.

Fixes reddit#187
@cshoe cshoe mentioned this issue Jun 29, 2018
Merged
cshoe added a commit to cshoe/baseplate that referenced this issue Aug 3, 2018
@cshoe
187 B3 Headers Support
c507f6a 
Add support for B3 trace headers whil continuing to support the old
trace headers. This change aims to allow both both B3 and the old
headers to be used as long as they contain identical values. For
example:

```
X-Trace: 1234567890abcdef
X-B3-TraceId: 1234567890abcdef
```

Change To Highlight

The old headers only allowed integer values for trace, span and parent
span ID fields. This change broadens that to 64 bit hex encoded strings.
Trace IDs can be either 64 or 128 bit.

Fixes reddit#187
cshoe added a commit to cshoe/baseplate that referenced this issue Aug 7, 2018
@cshoe
187 B3 Headers Support
eb71fff 
Add support for B3 trace headers whil continuing to support the old
trace headers. This change aims to allow both both B3 and the old
headers to be used as long as they contain identical values. For
example:

```
X-Trace: 1234567890
X-B3-TraceId: 1234567890
```

Fixes reddit#187
@cshoe cshoe closed this as completed in #188 Aug 7, 2018
cshoe added a commit that referenced this issue Aug 7, 2018
@cshoe
187 B3 Headers Support (#188)
46db4cd 
Add support for B3 trace headers whil continuing to support the old
trace headers. This change aims to allow both both B3 and the old
headers to be used as long as they contain identical values. For
example:

```
X-Trace: 1234567890
X-B3-TraceId: 1234567890
```

Fixes #187
Kaitaan pushed a commit that referenced this issue Nov 1, 2018
@cshoe @Kaitaan
187 B3 Headers Support (#188)
b04e43f 
Add support for B3 trace headers whil continuing to support the old
trace headers. This change aims to allow both both B3 and the old
headers to be used as long as they contain identical values. For
example:

```
X-Trace: 1234567890
X-B3-TraceId: 1234567890
```

Fixes #187
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cshoe