Add logger to yeoman generator #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,10 +1,14 @@ | |||
| import React from 'react'; | |||
| import rs from 'react-server'; | |||
There was a problem hiding this comment.
I've been leaning toward this convention:
import {logging} from 'react-server';Thoughts?
doug-wade
force-pushed
the
add-logger-to-generator
branch
4 times, most recently
from
6bb41f8
to
26c6d8e
Compare
| @@ -44,6 +44,7 @@ | |||
| ], | |||
| "envs": [ | |||
| "node" | |||
| ] | |||
| ], | |||
| "globals": ["__LOGGER__", "__CACHE", "__CHANNEL__"] | |||
There was a problem hiding this comment.
Why the other globals? They're not used, right? Just __LOGGER__?
doug-wade
force-pushed
the
add-logger-to-generator
branch
2 times, most recently
from
7640474
to
47c9a6d
Compare
|
Looks good. Thanks @doug-wade. 👍 |
doug-wade
force-pushed
the
add-logger-to-generator
branch
2 times, most recently
from
2f675ee
to
34e7155
Compare
|
Here's what it looks like |
doug-wade
force-pushed
the
add-logger-to-generator
branch
from
34e7155
to
52494d8
Compare
doug-wade
force-pushed
the
add-logger-to-generator
branch
from
52494d8
to
6a97edc
Compare
davidalber
pushed a commit
to davidalber/react-server
that referenced
this pull request
Jul 24, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Demonstrate how to use the logger. Addresses #209