Let webpack see CSS from dependencies #892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a dep has CSS, makes sense to bundle it. Fixes redfin#878.
sresant
approved these changes
Mar 10, 2017
kafeltz
approved these changes
Mar 10, 2017
mtrabelsi
reviewed
Mar 10, 2017
| @@ -181,7 +181,6 @@ function packageCodeForBrowser(entrypoints, outputDir, outputUrl, hot, minify, l | |||
| { | |||
| test: /\.css$/, | |||
| loader: extractTextLoader, | |||
There was a problem hiding this comment.
Please do not forget to remove the comma as well, we don't know when it breaks :-)
There was a problem hiding this comment.
@mtrabelsi Trailing commas in object literals are supported in node.
We actually require them in multi-line object literals like this specifically so we don't need to clutter our diffs with modification of the previous line when we add/remove the last item in an object literal. ;)
Thanks for the bug report and for looking at he patch!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a dep has CSS, makes sense to bundle it.
Fixes #878.