Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(STONEINTG-869): e2e test of gitlab integration reporting #1153

Merged

Conversation

kasemAlem
Copy link
Contributor

in this PR we implement happy-path of feature integration gilab reporting ensure that the build and integration pipelinerun are reported in the associated gitlab branch as we validate the status of pipelineruns succeeded as expected.
Signed-off-by: Kasem Alem kasem.alem@gmail.com

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

STONEINTG-869

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added meaningful description with JIRA/GitHub issue key(if applicable), for example HASSuiteDescribe("STONE-123456789 devfile source")
  • I have updated labels (if needed)

Copy link

openshift-ci bot commented May 7, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all


// For PaC Gitlab tests required project ID
GITLAB_PRIJECT_ID string = "PAC_PRIJECT_ID"

Copy link
Contributor Author

@kasemAlem kasemAlem May 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@psturc @dheerajodha @tisutisu @flacatus
I'm sure that the Token variable we want to add it to the CI vault,
for the two other ones GITLAB_URL_ENV and GITLAB_PRIJECT_ID should I use them as constant in code and not to be added to the vault ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for now I've added those three env variables to vault to make progress with this test,
I will modify once we decide .

@dirgim
Copy link
Contributor

dirgim commented May 10, 2024

/retest

@kasemAlem
Copy link
Contributor Author

kasemAlem commented May 10, 2024

@dirgim
we can retest this PR only after openshift PR is merged

@kasemAlem
Copy link
Contributor Author

/test redhat-appstudio-e2e

Copy link
Contributor

@dirgim dirgim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

@hongweiliu17 hongweiliu17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

in this PR we implement happy-path of feature integration gilab reporting
ensure that the build and integration pipelinerun are reported in the associated gitlab
branch as we validate the status of pipelineruns succeeded as expected.
Signed-off-by: Kasem Alem <kasem.alem@gmail.com>
Copy link

sonarcloud bot commented May 14, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Member

@dheerajodha dheerajodha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @kasemAlem!
/lgtm

Copy link

openshift-ci bot commented May 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dheerajodha, dirgim, hongweiliu17

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit ad0dac9 into konflux-ci:main May 14, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants