-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(STONEINTG-869): e2e test of gitlab integration reporting #1153
feat(STONEINTG-869): e2e test of gitlab integration reporting #1153
Conversation
Skipping CI for Draft Pull Request. |
|
||
// For PaC Gitlab tests required project ID | ||
GITLAB_PRIJECT_ID string = "PAC_PRIJECT_ID" | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@psturc @dheerajodha @tisutisu @flacatus
I'm sure that the Token variable we want to add it to the CI vault,
for the two other ones GITLAB_URL_ENV
and GITLAB_PRIJECT_ID
should I use them as constant in code and not to be added to the vault ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for now I've added those three env variables to vault to make progress with this test,
I will modify once we decide .
ebdbe4b
to
5d156f3
Compare
5d156f3
to
46161c2
Compare
/retest |
@dirgim |
/test redhat-appstudio-e2e |
46161c2
to
f698eff
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
f698eff
to
cbc2408
Compare
cbc2408
to
e1045d0
Compare
in this PR we implement happy-path of feature integration gilab reporting ensure that the build and integration pipelinerun are reported in the associated gitlab branch as we validate the status of pipelineruns succeeded as expected. Signed-off-by: Kasem Alem <kasem.alem@gmail.com>
e1045d0
to
0b7eb06
Compare
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @kasemAlem!
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dheerajodha, dirgim, hongweiliu17 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
in this PR we implement happy-path of feature integration gilab reporting ensure that the build and integration pipelinerun are reported in the associated gitlab branch as we validate the status of pipelineruns succeeded as expected.
Signed-off-by: Kasem Alem kasem.alem@gmail.com
Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.
STONEINTG-869
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: