Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update RBAC rules for Helm chart ClusterRole #67

Merged
merged 1 commit into from
Jul 29, 2020
Merged

Update RBAC rules for Helm chart ClusterRole #67

merged 1 commit into from
Jul 29, 2020

Conversation

milosgajdos
Copy link
Contributor

We are added RW access to apiservices in apiregistration.k8s.io API.

Fixes #66

@milosgajdos
Update RBAC rules for Helm chart ClusterRole
40d59fb 
We are added RW access to apiservices in apiregistration.k8s.io API
mathianasj
mathianasj approved these changes Jul 29, 2020
View reviewed changes
Copy link
Contributor

@mathianasj mathianasj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution, I validated building locally and deployed and confirmed this resolves the issue.

@mathianasj mathianasj merged commit 44dd7bc into redhat-cop:master Jul 29, 2020
@milosgajdos milosgajdos deleted the fix-helm-chart branch July 29, 2020 16:35
@milosgajdos milosgajdos mentioned this pull request Aug 12, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathianasj mathianasj mathianasj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Broken in OpenShift 4.5
2 participants
@milosgajdos @mathianasj