Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make cert validation for nexus variable #343

Merged
merged 2 commits into from
Mar 18, 2019
Merged

Conversation

sherl0cks
Copy link
Contributor

@sherl0cks sherl0cks commented Mar 18, 2019

What does this PR do?

Provides a var to control cert validation behavior throughout the role

How should this be tested?

You'll need to run the role against a nexus with self signed certs. See redhat-cop/container-pipelines#73 as an example pipeline

Is there a relevant Issue open for this?

Resolves #342

Other Relevant info, PRs, etc.

redhat-cop/container-pipelines#73 is blocked by this.

People to notify

cc: @redhat-cop/infra-ansible

@sherl0cks sherl0cks changed the title do not validate certs do not validate certs for nexus Mar 18, 2019
@sherl0cks sherl0cks changed the title do not validate certs for nexus make cert validation for nexus variable Mar 18, 2019
Copy link
Contributor

@oybed oybed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oybed oybed merged commit ab65d9b into redhat-cop:master Mar 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants