Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for issue #89 #94

Merged
merged 1 commit into from
Jun 17, 2020
Merged

Fix for issue #89 #94

merged 1 commit into from
Jun 17, 2020

Conversation

themoosman
Copy link
Collaborator

If bucket_access_point isn't specified, then Pelorus defaults to no LTS and uses the legacy Prometheus service endpoint.

resolves: #89

@themoosman themoosman requested a review from etsauer June 16, 2020 19:52
etsauer
etsauer approved these changes Jun 17, 2020
View reviewed changes
Copy link
Collaborator

@etsauer etsauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@etsauer etsauer merged commit 7e17fc8 into dora-metrics:master Jun 17, 2020
@themoosman themoosman deleted the issue-88 branch June 17, 2020 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etsauer etsauer etsauer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pelorus Grafana dashboard does not work if long term storage isn't used
2 participants
@themoosman @etsauer