Workaround for CRW-494 - disable pushing logs to server in init broker #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Angel Misevski <amisevsk@redhat.com>
|
crw_stable-branch_PR # 161: SUCCESS |
|
Just realized that this won't work if workspaces are ephemeral, since the regular broker is also provisioned as an init container. |
|
@dmytro-ndp any reason to make them ephemeral by default on CRW ? |
|
I am not aware about the reasons. |
|
Rejected in favour of #202 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a workaround for https://issues.jboss.org/browse/CRW-494 pending merge of PRs eclipse-che/che#15263, eclipse-che/che#15264.
During the docker build of the init container, we comment out the lines that attempt to connect to the server via websocket. Since upstream Che 7.3.2 does not provision proxy settings for the init container, connecting fails and this blocks workspace start. The only impact of removing these lines is that workspace start does not see the log message