-
Notifications
You must be signed in to change notification settings - Fork 125
[RHDX-244] Replace Foundation alert with New Panel UI component #3501
[RHDX-244] Replace Foundation alert with New Panel UI component #3501
Conversation
...drupal/drupal-filesystem/web/themes/custom/rhdp2/rhd-frontend/src/scripts/js/rhd/referrer.js
Show resolved
Hide resolved
...drupal/drupal-filesystem/web/themes/custom/rhdp2/rhd-frontend/src/scripts/js/rhd/referrer.js
Show resolved
Hide resolved
...ystem/web/themes/custom/rhdp2/rhd-frontend/src/styles/rhd-theme/components/_rhd-c-panel.scss
Outdated
Show resolved
Hide resolved
...l-filesystem/web/themes/custom/rhdp2/rhd-frontend/src/scripts/js/rhd/terms-and-conditions.js
Show resolved
Hide resolved
…oundation_alert_with_New_Panel_UI_component_RHDX_244
retest this please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked the rhd-c-panel for .callout.panel and it looks great. I checked the jbd referrer as an alert and that also looks great.
I did not test download thank you or 'terms and conditions' from the PR environment, I believe I need clearer steps to test that. Otherwise this looks great 👍
…oundation_alert_with_New_Panel_UI_component_RHDX_244
It looks like we need to revise the alert that displays after downloading a product. Steps to reproduce
|
After reviewing the JIRA issue, I see that this wasn't in the original scope of the ticket. If it seems reasonable to include this 'thank you' alert in the scope of this PR, please feel free to do so. If not, just let me know, and I can create a new JIRA issue to track this 'thank you' alert |
@jordanpagewhite the panel has been updated to the generic rhd-c-panel style, there is some cross-population with the old theme, I would be simpler to do this after we have removed the old theme or as part of removing it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alistairmc Looks great!
Great, thank you @alistairmc I will make an issue to track that 'Thank you' alert then. We can address it after we've removed the rhdp theme. That is a good point. I will merge this now. |
JIRA Issue Link
https://projects.engineering.redhat.com/browse/RHDX-244
Verification Process
go to https://developer-preview-3501.ext.us-west.dc.preprod.paas.redhat.com/products/eap/overview?referrer=jbd the alert at the top of the page should now have inline patternfly alert style.
Have removed callout style from rhdp2 and created rhd-c-panel as a new style for panels moving forward.