Skip to content
This repository has been archived by the owner on Nov 10, 2021. It is now read-only.

Conversation

alistairmc
Copy link
Contributor

@alistairmc alistairmc commented Feb 11, 2020

JIRA Issue Link

https://projects.engineering.redhat.com/browse/RHDX-244

Verification Process

go to https://developer-preview-3501.ext.us-west.dc.preprod.paas.redhat.com/products/eap/overview?referrer=jbd the alert at the top of the page should now have inline patternfly alert style.

Have removed callout style from rhdp2 and created rhd-c-panel as a new style for panels moving forward.

@alistairmc alistairmc changed the title [RHDX-244] Replace Foundation alert with New Panel UI component [do not merge][RHDX-244] Replace Foundation alert with New Panel UI component Feb 11, 2020
@alistairmc alistairmc changed the title [do not merge][RHDX-244] Replace Foundation alert with New Panel UI component [RHDX-244] Replace Foundation alert with New Panel UI component Feb 11, 2020
@robpblake
Copy link
Contributor

retest this please

@redhat-developer redhat-developer deleted a comment from alistairmc Feb 12, 2020
@staceymosier staceymosier self-requested a review February 12, 2020 17:26
Copy link
Contributor

@staceymosier staceymosier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked the rhd-c-panel for .callout.panel and it looks great. I checked the jbd referrer as an alert and that also looks great.

I did not test download thank you or 'terms and conditions' from the PR environment, I believe I need clearer steps to test that. Otherwise this looks great 👍

…oundation_alert_with_New_Panel_UI_component_RHDX_244
@alistairmc alistairmc self-assigned this Feb 13, 2020
@jordanpagewhite
Copy link
Contributor

Screen Shot 2020-02-13 at 9 16 24 AM

It looks like we need to revise the alert that displays after downloading a product.

Steps to reproduce

@jordanpagewhite
Copy link
Contributor

After reviewing the JIRA issue, I see that this wasn't in the original scope of the ticket. If it seems reasonable to include this 'thank you' alert in the scope of this PR, please feel free to do so. If not, just let me know, and I can create a new JIRA issue to track this 'thank you' alert

@alistairmc
Copy link
Contributor Author

@jordanpagewhite the panel has been updated to the generic rhd-c-panel style, there is some cross-population with the old theme, I would be simpler to do this after we have removed the old theme or as part of removing it.

Copy link

@gdoyle1 gdoyle1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alistairmc Looks great!

@jordanpagewhite
Copy link
Contributor

Great, thank you @alistairmc I will make an issue to track that 'Thank you' alert then. We can address it after we've removed the rhdp theme. That is a good point. I will merge this now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
5 participants