Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed log timestamp format #574

Conversation

ciiay
Copy link
Contributor

@ciiay ciiay commented Jul 20, 2023

What type of PR is this?

/kind enhancement

What does this PR do / why we need it:
Our log timestamp is not human readable.

Which issue(s) this PR fixes:

Fixes #?
GITOPS-2898: Operator logs should have human readable timestamps

How to test changes / Special notes to the reviewer:

  1. Have a k8s cluster running.
  2. Go to gitops-operator/ directory and run make install run. Observe the timestamps in log are in RFC3339 format e.g. 2023-06-27T07:12:48-04:00.

@openshift-ci openshift-ci bot added the kind/enhancement New feature or request label Jul 20, 2023
@ciiay ciiay requested review from jaideepr97 and removed request for svghadi and mehabhalodiya July 20, 2023 14:48
@jaideepr97
Copy link
Collaborator

/lgtm
/approved

@openshift-ci openshift-ci bot removed the lgtm label Jul 24, 2023
@iam-veeramalla
Copy link
Collaborator

/lgtm
/approve

@openshift-ci
Copy link

openshift-ci bot commented Jul 24, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: iam-veeramalla

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit ad3b52a into redhat-developer:master Jul 24, 2023
1 check passed
trdoyle81 pushed a commit to trdoyle81/gitops-operator that referenced this pull request Aug 13, 2024
Co-authored-by: Jaideep Rao <jaideep.r97@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants