Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated default version to 1.9.2 and tools kustomize, regctl, yq #601

Merged

Conversation

anandf
Copy link
Member

@anandf anandf commented Sep 12, 2023

What type of PR is this?
/kind bug

What does this PR do / why we need it:
Non OLM installation fails as the latest version of CRD manifests creates resources with creationTimestamp="null" this causes the builds to fail with error

error: unable to decode "/tmp/gitops-operator-install-dxw9u9c/kustomize-build-output.yaml": parsing time "null" as "2006-01-02T15:04:05Z07:00": cannot parse "null" as "2006"

Also, updated the default version and dependent tool versions - yq, kustomize and regctl
Have you updated the necessary documentation?

  • Documentation update is required by this PR.
  • Documentation has been updated.

Which issue(s) this PR fixes:

Fixes #?

Test acceptance criteria:

  • Unit Test
  • E2E Test

How to test changes / Special notes to the reviewer:

@openshift-ci openshift-ci bot added the kind/bug Something isn't working label Sep 12, 2023
@anandf
Copy link
Member Author

anandf commented Sep 12, 2023

/test v4.14-kuttl-sequential

Signed-off-by: Anand Francis Joseph <anjoseph@redhat.com>
Signed-off-by: Anand Francis Joseph <anjoseph@redhat.com>
Signed-off-by: Anand Francis Joseph <anjoseph@redhat.com>
Signed-off-by: Anand Francis Joseph <anjoseph@redhat.com>
Signed-off-by: Anand Francis Joseph <anjoseph@redhat.com>
Signed-off-by: Anand Francis Joseph <anjoseph@redhat.com>
Signed-off-by: Anand Francis Joseph <anjoseph@redhat.com>
Signed-off-by: Anand Francis Joseph <anjoseph@redhat.com>
Signed-off-by: Anand Francis Joseph <anjoseph@redhat.com>
Copy link
Collaborator

@jaideepr97 jaideepr97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @anandf

@openshift-ci
Copy link

openshift-ci bot commented Sep 21, 2023

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@anandf
Copy link
Member Author

anandf commented Sep 22, 2023

/retest-required

@anandf
Copy link
Member Author

anandf commented Sep 22, 2023

/test v4.13-kuttl-parallel

@anandf
Copy link
Member Author

anandf commented Sep 22, 2023

/retest-required

@openshift-merge-robot openshift-merge-robot merged commit 203c3a2 into redhat-developer:master Sep 22, 2023
18 checks passed
@anandf anandf deleted the fix_non_olm_installation branch September 25, 2023 09:30
trdoyle81 pushed a commit to trdoyle81/gitops-operator that referenced this pull request Aug 13, 2024
…hat-developer#601)

* Updated default version to 1.9.2 and tools kustomize, regctl, yq

Signed-off-by: Anand Francis Joseph <anjoseph@redhat.com>

* Using server side apply to avoid errors due to large annotation for CRDs

Signed-off-by: Anand Francis Joseph <anjoseph@redhat.com>

* Fix missing tls certificate secret

Signed-off-by: Anand Francis Joseph <anjoseph@redhat.com>

* Fixed resources missing for prometheus metrics

Signed-off-by: Anand Francis Joseph <anjoseph@redhat.com>

* Using a different version for RBAC manifests

Signed-off-by: Anand Francis Joseph <anjoseph@redhat.com>

* Added changes for enabling webhook

Signed-off-by: Anand Francis Joseph <anjoseph@redhat.com>

* Commenting out auth proxy related manifests that are not required

Signed-off-by: Anand Francis Joseph <anjoseph@redhat.com>

* Added missing space between commenting char #

Signed-off-by: Anand Francis Joseph <anjoseph@redhat.com>

* Fixed the kustomization file referring to anandf repository

Signed-off-by: Anand Francis Joseph <anjoseph@redhat.com>

---------

Signed-off-by: Anand Francis Joseph <anjoseph@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved kind/bug Something isn't working lgtm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants