Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating tests to work with mac #617

Merged
merged 2 commits into from
Nov 24, 2023

Conversation

anandrkskd
Copy link
Contributor

What type of PR is this?
/kind failing-test

What does this PR do / why we need it:
This PR solves failing tests on mac due to scipt used in the tests steps.

Have you updated the necessary documentation?

  • Documentation update is required by this PR.
  • Documentation has been updated.

Which issue(s) this PR fixes:

Fixes GITOPS-3481

Test acceptance criteria:

  • Unit Test
  • E2E Test

How to test changes / Special notes to the reviewer:

@openshift-ci openshift-ci bot added the kind/failing-test Categorizes issue or PR as related to a frequently failing test. label Nov 2, 2023
Signed-off-by: Anand Kumar Singh <anandrkskd@gmail.com>
@anandrkskd
Copy link
Contributor Author

@varshab1210 can you review and Merge this PR?

@varshab1210
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot removed the lgtm label Nov 24, 2023
Copy link

openshift-ci bot commented Nov 24, 2023

New changes are detected. LGTM label has been removed.

Copy link

openshift-ci bot commented Nov 24, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from varshab1210. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@iam-veeramalla iam-veeramalla merged commit 8152452 into redhat-developer:master Nov 24, 2023
1 check passed
@svghadi
Copy link
Member

svghadi commented Dec 15, 2023

/cherry-pick v1.11

@openshift-cherrypick-robot

@svghadi: new pull request could not be created: failed to create pull request against redhat-developer/gitops-operator#v1.11 from head openshift-cherrypick-robot:cherry-pick-617-to-v1.11: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"No commits between redhat-developer:v1.11 and openshift-cherrypick-robot:cherry-pick-617-to-v1.11"}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request"}

In response to this:

/cherry-pick v1.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@svghadi
Copy link
Member

svghadi commented Dec 15, 2023

/cherry-pick v1.10

@openshift-cherrypick-robot

@svghadi: new pull request created: #630

In response to this:

/cherry-pick v1.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

trdoyle81 pushed a commit to trdoyle81/gitops-operator that referenced this pull request Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/failing-test Categorizes issue or PR as related to a frequently failing test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants