Adjust completion test according to helm 3.4 flags #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pratikjagrut Thanks, have you considered/incorporated this fix helm#89 into your PR? |
@pavel I did not know about that PR. But if that change is already upstream then do we need this PR? |
|
@pratikjagrut Please consider #12 |
pmacik
pushed a commit
that referenced
this pull request
Oct 26, 2021
Fixes the completion tests failure by adjusting tests according to new changes flags changes in helm 3.4.
pmacik
pushed a commit
that referenced
this pull request
Oct 26, 2021
…m commits -update pip to pip3 -run openshift tests -Fix test data deployment version -Install PV before test setup and fix deamon set tests -Add helm dir in .acceptance -Change to use current helm bin -Disable test for version greater than 3.1 -Create blank.yml -Enable tests related to Helm 3.2 bin. (#2) -Add openshift cluster provider (#6) * Run acceptance tests against provided k8s cluster * Add openshift cluster provider -Fix kubeVersion to support kube pre-releases (helm/helm#6190) (#9) -Remove obsolete and redundand test cases from kubernetes_versions.robot (#12) -Adjust completion test according to helm 3.4 flags (#11) -Fixes the completion tests failure by adjusting tests according to new changes flags changes in helm 3.4. Signed-off-by: Pavel Macík <pavel.macik@gmail.com>
pmacik
pushed a commit
that referenced
this pull request
Apr 5, 2022
…m commits -update pip to pip3 -run openshift tests -Fix test data deployment version -Install PV before test setup and fix deamon set tests -Add helm dir in .acceptance -Change to use current helm bin -Disable test for version greater than 3.1 -Create blank.yml -Enable tests related to Helm 3.2 bin. (#2) -Add openshift cluster provider (#6) * Run acceptance tests against provided k8s cluster * Add openshift cluster provider -Fix kubeVersion to support kube pre-releases (helm/helm#6190) (#9) -Remove obsolete and redundand test cases from kubernetes_versions.robot (#12) -Adjust completion test according to helm 3.4 flags (#11) -Fixes the completion tests failure by adjusting tests according to new changes flags changes in helm 3.4. Signed-off-by: Pavel Macík <pavel.macik@gmail.com>
pmacik
added a commit
that referenced
this pull request
Apr 5, 2022
…m commits -update pip to pip3 -run openshift tests -Fix test data deployment version -Install PV before test setup and fix deamon set tests -Add helm dir in .acceptance -Change to use current helm bin -Disable test for version greater than 3.1 -Create blank.yml -Enable tests related to Helm 3.2 bin. (#2) -Add openshift cluster provider (#6) * Run acceptance tests against provided k8s cluster * Add openshift cluster provider -Fix kubeVersion to support kube pre-releases (helm/helm#6190) (#9) -Remove obsolete and redundand test cases from kubernetes_versions.robot (#12) -Adjust completion test according to helm 3.4 flags (#11) -Fixes the completion tests failure by adjusting tests according to new changes flags changes in helm 3.4. Co-authored-by: Akash Shinde <akashshinde159@gmail.com> Signed-off-by: Pavel Macík <pavel.macik@gmail.com>
pmacik
added a commit
that referenced
this pull request
Apr 5, 2022
…m commits -update pip to pip3 -run openshift tests -Fix test data deployment version -Install PV before test setup and fix deamon set tests -Add helm dir in .acceptance -Change to use current helm bin -Disable test for version greater than 3.1 -Create blank.yml -Enable tests related to Helm 3.2 bin. (#2) -Add openshift cluster provider (#6) * Run acceptance tests against provided k8s cluster * Add openshift cluster provider -Fix kubeVersion to support kube pre-releases (helm/helm#6190) (#9) -Remove obsolete and redundand test cases from kubernetes_versions.robot (#12) -Adjust completion test according to helm 3.4 flags (#11) -Fixes the completion tests failure by adjusting tests according to new changes flags changes in helm 3.4. Co-authored-by: Akash Shinde <akashshinde159@gmail.com> Signed-off-by: Pavel Macík <pavel.macik@gmail.com>
tisutisu
pushed a commit
that referenced
this pull request
Sep 22, 2022
…m commits -update pip to pip3 -run openshift tests -Fix test data deployment version -Install PV before test setup and fix deamon set tests -Add helm dir in .acceptance -Change to use current helm bin -Disable test for version greater than 3.1 -Create blank.yml -Enable tests related to Helm 3.2 bin. (#2) -Add openshift cluster provider (#6) * Run acceptance tests against provided k8s cluster * Add openshift cluster provider -Fix kubeVersion to support kube pre-releases (helm/helm#6190) (#9) -Remove obsolete and redundand test cases from kubernetes_versions.robot (#12) -Adjust completion test according to helm 3.4 flags (#11) -Fixes the completion tests failure by adjusting tests according to new changes flags changes in helm 3.4. Modified the openshift-nginx chart to work properly in 4.12 Co-authored-by: Akash Shinde <akashshinde159@gmail.com> Co-authored-by: Sushanta Das <sushanta.das.ju@gmail.com> Signed-off-by: Pavel Macík <pavel.macik@gmail.com>
tisutisu
pushed a commit
that referenced
this pull request
Nov 23, 2022
…m commits -update pip to pip3 -run openshift tests -Fix test data deployment version -Install PV before test setup and fix deamon set tests -Add helm dir in .acceptance -Change to use current helm bin -Disable test for version greater than 3.1 -Create blank.yml -Enable tests related to Helm 3.2 bin. (#2) -Add openshift cluster provider (#6) * Run acceptance tests against provided k8s cluster * Add openshift cluster provider -Fix kubeVersion to support kube pre-releases (helm/helm#6190) (#9) -Remove obsolete and redundand test cases from kubernetes_versions.robot (#12) -Adjust completion test according to helm 3.4 flags (#11) -Fixes the completion tests failure by adjusting tests according to new changes flags changes in helm 3.4. Modified the openshift-nginx chart to work properly in 4.12 Co-authored-by: Akash Shinde <akashshinde159@gmail.com> Co-authored-by: Sushanta Das <sushanta.das.ju@gmail.com> Signed-off-by: Pavel Macík <pavel.macik@gmail.com>
Kartikey-star
pushed a commit
that referenced
this pull request
Feb 28, 2023
…m commits -update pip to pip3 -run openshift tests -Fix test data deployment version -Install PV before test setup and fix deamon set tests -Add helm dir in .acceptance -Change to use current helm bin -Disable test for version greater than 3.1 -Create blank.yml -Enable tests related to Helm 3.2 bin. (#2) -Add openshift cluster provider (#6) * Run acceptance tests against provided k8s cluster * Add openshift cluster provider -Fix kubeVersion to support kube pre-releases (helm/helm#6190) (#9) -Remove obsolete and redundand test cases from kubernetes_versions.robot (#12) -Adjust completion test according to helm 3.4 flags (#11) -Fixes the completion tests failure by adjusting tests according to new changes flags changes in helm 3.4. Modified the openshift-nginx chart to work properly in 4.12 Co-authored-by: Akash Shinde <akashshinde159@gmail.com> Co-authored-by: Sushanta Das <sushanta.das.ju@gmail.com> Signed-off-by: Pavel Macík <pavel.macik@gmail.com>
Kartikey-star
pushed a commit
that referenced
this pull request
Mar 2, 2023
…m commits -update pip to pip3 -run openshift tests -Fix test data deployment version -Install PV before test setup and fix deamon set tests -Add helm dir in .acceptance -Change to use current helm bin -Disable test for version greater than 3.1 -Create blank.yml -Enable tests related to Helm 3.2 bin. (#2) -Add openshift cluster provider (#6) * Run acceptance tests against provided k8s cluster * Add openshift cluster provider -Fix kubeVersion to support kube pre-releases (helm/helm#6190) (#9) -Remove obsolete and redundand test cases from kubernetes_versions.robot (#12) -Adjust completion test according to helm 3.4 flags (#11) -Fixes the completion tests failure by adjusting tests according to new changes flags changes in helm 3.4. Modified the openshift-nginx chart to work properly in 4.12 Co-authored-by: Akash Shinde <akashshinde159@gmail.com> Co-authored-by: Sushanta Das <sushanta.das.ju@gmail.com> Signed-off-by: Pavel Macík <pavel.macik@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the completion tests failure by adjusting tests according to new changes flags changes in helm 3.4.
Tested against helm version
Helm bin link: https://github.com/helm/helm/releases/tag/v3.4.2