Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable tests related to Helm 3.2 bin. #2

Merged

Conversation

pratikjagrut
Copy link

@pratikjagrut pratikjagrut commented May 29, 2020

Enable shells tests for Helm 3.2 which were disabled for Helm 3.1.

Copy link
Collaborator

@pmacik pmacik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the end-of-file new-line, LGTM.
Verified with helm v3.2.1

scripts/completion-tests/completionTests.sh Outdated Show resolved Hide resolved
@pratikjagrut pratikjagrut requested a review from pmacik May 29, 2020 10:02
Copy link
Collaborator

@pmacik pmacik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pmacik pmacik self-requested a review June 11, 2020 05:14
Copy link
Collaborator

@pmacik pmacik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pratikjagrut Please squash the commits and put a nice commit message explaining the change including the sign-off.

Signed-off-by: Pratik Jagrut <26519653+pratikjagrut@users.noreply.github.com>
@pmacik pmacik merged commit 9b5a421 into redhat-developer:helm-3.2-openshift Jun 11, 2020
pmacik pushed a commit that referenced this pull request Sep 29, 2020
Signed-off-by: Pratik Jagrut <26519653+pratikjagrut@users.noreply.github.com>
pedjak pushed a commit that referenced this pull request Dec 16, 2020
Signed-off-by: Pratik Jagrut <26519653+pratikjagrut@users.noreply.github.com>
pmacik pushed a commit that referenced this pull request Oct 26, 2021
Signed-off-by: Pratik Jagrut <26519653+pratikjagrut@users.noreply.github.com>
pmacik pushed a commit that referenced this pull request Oct 26, 2021
…m commits

-update pip to pip3

-run openshift tests

-Fix test data deployment version

-Install PV before test setup and fix deamon set tests

-Add helm dir in .acceptance

-Change to use current helm bin

-Disable test for version greater than 3.1

-Create blank.yml

-Enable tests related to Helm 3.2 bin. (#2)

-Add openshift cluster provider (#6)
* Run acceptance tests against provided k8s cluster
* Add openshift cluster provider

-Fix kubeVersion to support kube pre-releases (helm/helm#6190) (#9)

-Remove obsolete and redundand test cases from kubernetes_versions.robot (#12)

-Adjust completion test according to helm 3.4 flags (#11)

-Fixes the completion tests failure by adjusting tests according to new changes flags changes in helm 3.4.

Signed-off-by: Pavel Macík <pavel.macik@gmail.com>
pmacik pushed a commit that referenced this pull request Apr 5, 2022
…m commits

-update pip to pip3

-run openshift tests

-Fix test data deployment version

-Install PV before test setup and fix deamon set tests

-Add helm dir in .acceptance

-Change to use current helm bin

-Disable test for version greater than 3.1

-Create blank.yml

-Enable tests related to Helm 3.2 bin. (#2)

-Add openshift cluster provider (#6)
* Run acceptance tests against provided k8s cluster
* Add openshift cluster provider

-Fix kubeVersion to support kube pre-releases (helm/helm#6190) (#9)

-Remove obsolete and redundand test cases from kubernetes_versions.robot (#12)

-Adjust completion test according to helm 3.4 flags (#11)

-Fixes the completion tests failure by adjusting tests according to new changes flags changes in helm 3.4.

Signed-off-by: Pavel Macík <pavel.macik@gmail.com>
pmacik added a commit that referenced this pull request Apr 5, 2022
…m commits

-update pip to pip3

-run openshift tests

-Fix test data deployment version

-Install PV before test setup and fix deamon set tests

-Add helm dir in .acceptance

-Change to use current helm bin

-Disable test for version greater than 3.1

-Create blank.yml

-Enable tests related to Helm 3.2 bin. (#2)

-Add openshift cluster provider (#6)
* Run acceptance tests against provided k8s cluster
* Add openshift cluster provider

-Fix kubeVersion to support kube pre-releases (helm/helm#6190) (#9)

-Remove obsolete and redundand test cases from kubernetes_versions.robot (#12)

-Adjust completion test according to helm 3.4 flags (#11)

-Fixes the completion tests failure by adjusting tests according to new changes flags changes in helm 3.4.

Co-authored-by: Akash Shinde <akashshinde159@gmail.com>

Signed-off-by: Pavel Macík <pavel.macik@gmail.com>
pmacik added a commit that referenced this pull request Apr 5, 2022
…m commits

-update pip to pip3

-run openshift tests

-Fix test data deployment version

-Install PV before test setup and fix deamon set tests

-Add helm dir in .acceptance

-Change to use current helm bin

-Disable test for version greater than 3.1

-Create blank.yml

-Enable tests related to Helm 3.2 bin. (#2)

-Add openshift cluster provider (#6)
* Run acceptance tests against provided k8s cluster
* Add openshift cluster provider

-Fix kubeVersion to support kube pre-releases (helm/helm#6190) (#9)

-Remove obsolete and redundand test cases from kubernetes_versions.robot (#12)

-Adjust completion test according to helm 3.4 flags (#11)

-Fixes the completion tests failure by adjusting tests according to new changes flags changes in helm 3.4.

Co-authored-by: Akash Shinde <akashshinde159@gmail.com>

Signed-off-by: Pavel Macík <pavel.macik@gmail.com>
tisutisu pushed a commit that referenced this pull request Sep 22, 2022
…m commits

-update pip to pip3

-run openshift tests

-Fix test data deployment version

-Install PV before test setup and fix deamon set tests

-Add helm dir in .acceptance

-Change to use current helm bin

-Disable test for version greater than 3.1

-Create blank.yml

-Enable tests related to Helm 3.2 bin. (#2)

-Add openshift cluster provider (#6)
* Run acceptance tests against provided k8s cluster
* Add openshift cluster provider

-Fix kubeVersion to support kube pre-releases (helm/helm#6190) (#9)

-Remove obsolete and redundand test cases from kubernetes_versions.robot (#12)

-Adjust completion test according to helm 3.4 flags (#11)

-Fixes the completion tests failure by adjusting tests according to new changes flags changes in helm 3.4.

Modified the openshift-nginx chart to work properly in 4.12

Co-authored-by: Akash Shinde <akashshinde159@gmail.com>
Co-authored-by: Sushanta Das <sushanta.das.ju@gmail.com>

Signed-off-by: Pavel Macík <pavel.macik@gmail.com>
tisutisu pushed a commit that referenced this pull request Nov 23, 2022
…m commits

-update pip to pip3

-run openshift tests

-Fix test data deployment version

-Install PV before test setup and fix deamon set tests

-Add helm dir in .acceptance

-Change to use current helm bin

-Disable test for version greater than 3.1

-Create blank.yml

-Enable tests related to Helm 3.2 bin. (#2)

-Add openshift cluster provider (#6)
* Run acceptance tests against provided k8s cluster
* Add openshift cluster provider

-Fix kubeVersion to support kube pre-releases (helm/helm#6190) (#9)

-Remove obsolete and redundand test cases from kubernetes_versions.robot (#12)

-Adjust completion test according to helm 3.4 flags (#11)

-Fixes the completion tests failure by adjusting tests according to new changes flags changes in helm 3.4.

Modified the openshift-nginx chart to work properly in 4.12

Co-authored-by: Akash Shinde <akashshinde159@gmail.com>
Co-authored-by: Sushanta Das <sushanta.das.ju@gmail.com>

Signed-off-by: Pavel Macík <pavel.macik@gmail.com>
Kartikey-star pushed a commit that referenced this pull request Feb 28, 2023
…m commits

-update pip to pip3

-run openshift tests

-Fix test data deployment version

-Install PV before test setup and fix deamon set tests

-Add helm dir in .acceptance

-Change to use current helm bin

-Disable test for version greater than 3.1

-Create blank.yml

-Enable tests related to Helm 3.2 bin. (#2)

-Add openshift cluster provider (#6)
* Run acceptance tests against provided k8s cluster
* Add openshift cluster provider

-Fix kubeVersion to support kube pre-releases (helm/helm#6190) (#9)

-Remove obsolete and redundand test cases from kubernetes_versions.robot (#12)

-Adjust completion test according to helm 3.4 flags (#11)

-Fixes the completion tests failure by adjusting tests according to new changes flags changes in helm 3.4.

Modified the openshift-nginx chart to work properly in 4.12

Co-authored-by: Akash Shinde <akashshinde159@gmail.com>
Co-authored-by: Sushanta Das <sushanta.das.ju@gmail.com>

Signed-off-by: Pavel Macík <pavel.macik@gmail.com>
Kartikey-star pushed a commit that referenced this pull request Mar 2, 2023
…m commits

-update pip to pip3

-run openshift tests

-Fix test data deployment version

-Install PV before test setup and fix deamon set tests

-Add helm dir in .acceptance

-Change to use current helm bin

-Disable test for version greater than 3.1

-Create blank.yml

-Enable tests related to Helm 3.2 bin. (#2)

-Add openshift cluster provider (#6)
* Run acceptance tests against provided k8s cluster
* Add openshift cluster provider

-Fix kubeVersion to support kube pre-releases (helm/helm#6190) (#9)

-Remove obsolete and redundand test cases from kubernetes_versions.robot (#12)

-Adjust completion test according to helm 3.4 flags (#11)

-Fixes the completion tests failure by adjusting tests according to new changes flags changes in helm 3.4.

Modified the openshift-nginx chart to work properly in 4.12

Co-authored-by: Akash Shinde <akashshinde159@gmail.com>
Co-authored-by: Sushanta Das <sushanta.das.ju@gmail.com>

Signed-off-by: Pavel Macík <pavel.macik@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants