Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Associate LSP bundle download with app preload instead of project #36

Merged
merged 4 commits into from
Mar 18, 2021

Conversation

arajkumar
Copy link
Contributor

Associating LSP bundle download with project causing issues when developers opens more than one project.(causes multiple LSP download and other exceptions)

Signed-off-by: Arunprasad Rajkumar ar.arunprasad@gmail.com

…roject

Signed-off-by: Arunprasad Rajkumar <ar.arunprasad@gmail.com>
Signed-off-by: Arunprasad Rajkumar <ar.arunprasad@gmail.com>
@arajkumar arajkumar marked this pull request as ready for review February 23, 2021 04:38
Signed-off-by: Arunprasad Rajkumar <ar.arunprasad@gmail.com>
@arajkumar arajkumar changed the title refactor: Associate LSP bundle download with app preload instead of project fix: Associate LSP bundle download with app preload instead of project Feb 25, 2021
@arajkumar
Copy link
Contributor Author

@jeffmaury PTAL

@jeffmaury
Copy link
Member

Looks to me that server is downloaded each time IDE is started.
I looked at build/idea-sandbox/plugins/org.jboss.tools.intellij.analytics folder and found that analytics-lsp-win.exe got refreshed (modified date) each time I launch IDE
Also searched for the analytics.settings.xml in the build folder and could not find it

@arajkumar
Copy link
Contributor Author

@jeffmaury , this is a problem with dev mode, can you check it by installing the plugin jar?

@jeffmaury
Copy link
Member

Can you elaborate why it is not working in dev mode, I really don't like these debug sessions where you have to package your stuff and deploy it

@arajkumar
Copy link
Contributor Author

@jeffmaury It is problem in runIde task itself, please check JetBrains/intellij-platform-gradle-plugin#188

@jeffmaury
Copy link
Member

You still have an issue as your Setting class cannot be serialized/deserialized thus I can't find it after I run runIde
See the warning when you stop the IDE

Signed-off-by: Jeff MAURY <jmaury@redhat.com>
@sonarcloud
Copy link

sonarcloud bot commented Mar 4, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@arajkumar
Copy link
Contributor Author

@jeffmaury Thanks for fixing it, I missed that it need to be JavaBean :)
https://plugins.jetbrains.com/docs/intellij/persisting-state-of-components.html#implementing-the-state-class

@jeffmaury
Copy link
Member

@arajkumar ok to merge ?

@arajkumar
Copy link
Contributor Author

@arajkumar ok to merge ?

@jeffmaury. yes.

(sorry, I missed this message)

@jeffmaury jeffmaury merged commit 3bed458 into redhat-developer:master Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants