Add basic UI test that creates new Quarkus project and builds it using maven #234

zcervink · 2020-09-21T10:22:24Z

Fixes: #216

Signed-off-by: Zbynek Cervinka zcervink@redhat.com

jeffmaury · 2020-09-22T09:45:58Z

Great work. However, it uses a separate sub project which would make it more difficult to write new tests.
Would it be possible to:

move the sources to src/it/java and src/it/resources
add the require Gradle configuration in build.gradle (see the OpenShift Connector)
add the integration tests execution in the main Github Actions so that we run the integration tests as well

jkopriva · 2020-09-22T09:49:47Z

gui-tests/src/test/java/org/jboss/tools/intellij/quarkus/BasicTests.java

+
+import static com.intellij.remoterobot.stepsProcessing.StepWorkerKt.step;
+
+


There should be also author and also short description what it does.

I have added author and comments to every Java file.

jkopriva · 2020-09-22T09:50:47Z

gui-tests/run_the_tests.sh

@@ -0,0 +1,16 @@
+#! /bin/bash


Please add also short description, what it does.

There is no need for adding a description after all, because the script has been deleted (it was just a temporary script until the gradle issue is resolved).

…g maven. Fixes: 216 Signed-off-by: Zbynek Cervinka <zcervink@redhat.com>

odockal · 2020-09-30T07:39:40Z

@zcervink @jkopriva I think it can be merged how it is. Another refactoring and creating a lib can be done in next turn.

jeffmaury

Also the main workflow (CI.yml) should also be updated to run integration tests

jeffmaury · 2020-09-30T10:29:11Z

build.gradle

@@ -80,6 +106,10 @@ dependencies {
    compile 'org.eclipse.lsp4mp:org.eclipse.lsp4mp.ls:0.1.0'
    compile 'org.eclipse.lsp4j:org.eclipse.lsp4j:0.8.1'
    compile 'com.vladsch.flexmark:flexmark:0.50.50'
+    testImplementation("com.intellij.remoterobot:remote-robot:$remoteRobotVersion")


should be integrationTestImplementation

jeffmaury · 2020-09-30T10:29:30Z

build.gradle

@@ -110,5 +144,27 @@ jacocoTestReport {

 check.dependsOn jacocoTestReport

+subprojects {


Should be removed

jrichter1 · 2020-09-30T10:48:59Z

src/it/java/org/jboss/tools/intellij/quarkus/utils/GlobalUtils.java

+
+    public static void waitUntilTheProjectImportIsComplete(RemoteRobot remoteRobot) {
+        step("Wait until the project import is complete", () -> {
+            while (true) {


There is a built-in method for conditional waits in com.intellij.remoterobot.utils.RepeatUtilsKt called waitFor. Please use that instead of endless loops.

@jrichter1 Thank you very much for this advice. The infinite while loops have been replace with the waitFor() method.

jeffmaury · 2020-09-30T14:03:47Z

I tested it on my Win10Pro laptop and it failed from me:

run ./gradlew runIdeForUiTests in one Windows shell
run ./gradlew integrationTest in another

Here is the log:

$ ./gradlew integrationTest                                                                                                                                                            
                                                                                                                                                                                       
> Task :integrationTest                                                                                                                                                                
                                                                                                                                                                                       
org.jboss.tools.intellij.quarkus.BasicTests                                                                                                                                            
                                                                                                                                                                                       
  Test createAQuarkusProjectAndBuildItUsingMaven() FAILED (22.7s)                                                                                                                      
                                                                                                                                                                                       
  com.intellij.remoterobot.utils.WaitForConditionTimeoutException: Exceeded timeout (PT20S) for condition function (Failed to find 'New Project Dialog' by 'MyDialog type' in 20s)     
      at org.jboss.tools.intellij.quarkus.BasicTests.lambda$createAQuarkusProjectAndBuildItUsingMaven$0(BasicTests.java:53)                                                            
                                                                                                                                                                                       
                                                                                                                                                                                       
FAILURE: Executed 1 tests in 33.1s (1 failed)                                                                                                                                          
                                                                                                                                                                                       
                                                                                                                                                                                       
1 test completed, 1 failed                                                                                                                                                             
                                                                                                                                                                                       
> Task :integrationTest FAILED

Signed-off-by: Zbynek Cervinka <zcervink@redhat.com>

jeffmaury · 2020-10-01T15:02:51Z

build.gradle

    id "com.adarshr.test-logger" version "1.7.0"
+    id 'org.jetbrains.kotlin.jvm' version '1.3.71'


Should be removed

jeffmaury · 2020-10-02T13:52:15Z

build.gradle

+    useJUnitPlatform()
+}
+
+wrapper {


Last question: what is the rationale for this ?

Removed. I have copied it from other gradle configuration, now I see it is not necessary.

Signed-off-by: Zbynek Cervinka <zcervink@redhat.com>

zcervink · 2020-10-06T09:59:16Z

I tested it on my Win10Pro laptop and it failed from me:

run ./gradlew runIdeForUiTests in one Windows shell
run ./gradlew integrationTest in another

Here is the log:

$ ./gradlew integrationTest                                                                                                                                                            
                                                                                                                                                                                       
> Task :integrationTest                                                                                                                                                                
                                                                                                                                                                                       
org.jboss.tools.intellij.quarkus.BasicTests                                                                                                                                            
                                                                                                                                                                                       
  Test createAQuarkusProjectAndBuildItUsingMaven() FAILED (22.7s)                                                                                                                      
                                                                                                                                                                                       
  com.intellij.remoterobot.utils.WaitForConditionTimeoutException: Exceeded timeout (PT20S) for condition function (Failed to find 'New Project Dialog' by 'MyDialog type' in 20s)     
      at org.jboss.tools.intellij.quarkus.BasicTests.lambda$createAQuarkusProjectAndBuildItUsingMaven$0(BasicTests.java:53)                                                            
                                                                                                                                                                                       
                                                                                                                                                                                       
FAILURE: Executed 1 tests in 33.1s (1 failed)                                                                                                                                          
                                                                                                                                                                                       
                                                                                                                                                                                       
1 test completed, 1 failed                                                                                                                                                             
                                                                                                                                                                                       
> Task :integrationTest FAILED

This sometimes happens because there is a delay before the IDE UI appears. We are working on this issue with Jan Richter, for now you need run the ./gradlew runIdeForUiTests command, wait until the UI appears and then run the ./gradlew integrationTest command. There is also an issue with the IDE version - the tests best run on the IC-2020.1 version, some older version has sometimes different UI and the build fails (#242).

Signed-off-by: Zbynek Cervinka <zcervink@redhat.com>

zcervink · 2020-10-06T13:45:59Z

@jeffmaury All requested changes from you and from @jrichter1 have been made. Can you make final review/merge if possible?

jeffmaury · 2020-10-06T13:48:46Z

build.gradle

+    integrationTestImplementation("com.intellij.remoterobot:remote-robot:$remoteRobotVersion")
+    integrationTestImplementation("com.intellij.remoterobot:remote-fixtures:$fixturesVersion")
+    integrationTestImplementation 'org.junit.jupiter:junit-jupiter-api:5.3.1'
+    testRuntimeOnly 'org.junit.jupiter:junit-jupiter-engine:5.3.1'


Should'n it be integrationTestRuntimeOnly ?

Signed-off-by: Zbynek Cervinka <zcervink@redhat.com>

jeffmaury

Congrats. Major improvment

zcervink force-pushed the 216 branch from c193d67 to d57a551 Compare September 21, 2020 10:56

jkopriva reviewed Sep 22, 2020

View reviewed changes

zcervink force-pushed the 216 branch 4 times, most recently from 9bee9fc to d06d6e3 Compare September 27, 2020 07:57

Add basic UI test that creates new Quarkus project and builds it usin…

67bbab0

…g maven. Fixes: 216 Signed-off-by: Zbynek Cervinka <zcervink@redhat.com>

zcervink force-pushed the 216 branch from d06d6e3 to 67bbab0 Compare September 27, 2020 11:00

jeffmaury requested changes Sep 30, 2020

View reviewed changes

jrichter1 reviewed Sep 30, 2020

View reviewed changes

Replace infinite while loops with Remote-Robot's waitFor()

19ede0b

Signed-off-by: Zbynek Cervinka <zcervink@redhat.com>

jeffmaury requested changes Oct 1, 2020

View reviewed changes

zcervink force-pushed the 216 branch 2 times, most recently from b04eea1 to 672e51d Compare October 2, 2020 13:36

jeffmaury reviewed Oct 2, 2020

View reviewed changes

Refactoring the build.gradle file.

bd50889

Signed-off-by: Zbynek Cervinka <zcervink@redhat.com>

zcervink force-pushed the 216 branch from 672e51d to bd50889 Compare October 2, 2020 14:43

zcervink added 2 commits October 6, 2020 12:38

Remove unnecessary gradle configuration.

917f5d6

Signed-off-by: Zbynek Cervinka <zcervink@redhat.com>

Replacing one while loop with waitFor()

ff7b56f

Signed-off-by: Zbynek Cervinka <zcervink@redhat.com>

zcervink force-pushed the 216 branch from 460055d to ff7b56f Compare October 6, 2020 12:25

jeffmaury reviewed Oct 6, 2020

View reviewed changes

Fix gradle configuration for UI tests.

7e2a46b

Signed-off-by: Zbynek Cervinka <zcervink@redhat.com>

jeffmaury approved these changes Oct 6, 2020

View reviewed changes

jeffmaury merged commit 093ffae into redhat-developer:master Oct 6, 2020

zcervink deleted the 216 branch October 7, 2020 07:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add basic UI test that creates new Quarkus project and builds it using maven #234

Add basic UI test that creates new Quarkus project and builds it using maven #234

zcervink commented Sep 21, 2020 •

edited by jeffmaury

Loading

jeffmaury commented Sep 22, 2020

jkopriva Sep 22, 2020

zcervink Sep 24, 2020

jkopriva Sep 22, 2020

zcervink Sep 26, 2020

odockal commented Sep 30, 2020

jeffmaury left a comment

jeffmaury Sep 30, 2020

zcervink Oct 6, 2020

jeffmaury Sep 30, 2020

zcervink Oct 6, 2020

jrichter1 Sep 30, 2020

zcervink Sep 30, 2020 •

edited

Loading

jeffmaury commented Sep 30, 2020

jeffmaury Oct 1, 2020

zcervink Oct 6, 2020

jeffmaury Oct 2, 2020

zcervink Oct 6, 2020

zcervink commented Oct 6, 2020

zcervink commented Oct 6, 2020

jeffmaury Oct 6, 2020

jeffmaury left a comment


		import static com.intellij.remoterobot.stepsProcessing.StepWorkerKt.step;

		@@ -110,5 +144,27 @@ jacocoTestReport {

		check.dependsOn jacocoTestReport

		subprojects {

		id "com.adarshr.test-logger" version "1.7.0"
		id 'org.jetbrains.kotlin.jvm' version '1.3.71'

Add basic UI test that creates new Quarkus project and builds it using maven #234

Add basic UI test that creates new Quarkus project and builds it using maven #234

Conversation

zcervink commented Sep 21, 2020 • edited by jeffmaury Loading

jeffmaury commented Sep 22, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

odockal commented Sep 30, 2020

jeffmaury left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

zcervink Sep 30, 2020 • edited Loading

Choose a reason for hiding this comment

jeffmaury commented Sep 30, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

zcervink commented Oct 6, 2020

zcervink commented Oct 6, 2020

Choose a reason for hiding this comment

jeffmaury left a comment

Choose a reason for hiding this comment

zcervink commented Sep 21, 2020 •

edited by jeffmaury

Loading

zcervink Sep 30, 2020 •

edited

Loading