Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

odo describe should also show secrets / linked variables from other components and services #2232

Closed
cdrage opened this issue Oct 2, 2019 · 1 comment · Fixed by #2233
Closed

odo describe should also show secrets / linked variables from other components and services #2232

cdrage opened this issue Oct 2, 2019 · 1 comment · Fixed by #2233

Comments

@cdrage
Copy link
Member

cdrage commented Oct 2, 2019

[kind/Enhancement]

Which functionality do you think we should update/improve?

When we use odo describe:

Component Name: nodejs-nodejs-ex-cstb
Type: nodejs
Source: file://./
Environment Variables:
 · foo=bar
 · bar=foo
 · DEBUG_PORT=5858
Storage:
 · mystorage of size 1Gi mounted to /opt/app-root/src/storage/
URLs:
 · http://foobar-app-myproject.192.168.42.79.nip.io exposed via 8080
Linked Components:
 · nodejs2 - Port(s): 8080
Linked Services:
 · mongodb-persistent
 · dh-mysql-apb

We should also link what secrets have been passed in via Linked Services

Why is this needed?

More information / easier to add / edit environment variables for front-end applications.
cdrage added a commit to cdrage/odo that referenced this issue Oct 2, 2019
@cdrage
Add secrets to odo describe
82d5e7d 
Adds the "secrets" or environment variables that have been passed into
the component by using the `odo link` feature when connecting to a
database.

Builds upon PR: redhat-developer#2231
Closes: redhat-developer#2232

See the below example of how it now looks like:

```sh
Component Name: nodejs-nodejs-ex-cstb
Type: nodejs
Source: file://./
Environment Variables:
 · foo=bar
 · bar=foo
 · DEBUG_PORT=5858
Storage:
 · mystorage of size 1Gi mounted to /opt/app-root/src/storage/
URLs:
 · http://foobar-app-myproject.192.168.42.79.nip.io exposed via 8080
Linked Components:
 · nodejs2 - Port(s): 8080
Linked Services:
 · mongodb-persistent
   Environment Variables:
    · uri
    · username
    · admin_password
    · database_name
    · password
 · dh-mysql-apb
   Environment Variables:
    · DB_HOST
    · DB_NAME
    · DB_PASSWORD
    · DB_PORT
    · DB_TYPE
    · DB_USER
```
@cdrage cdrage mentioned this issue Oct 2, 2019
Merged
@cdrage
Copy link
Member Author

cdrage commented Oct 2, 2019

PR open here: #2233

cdrage added a commit to cdrage/odo that referenced this issue Oct 7, 2019
@cdrage
Add secrets to odo describe
123d3a4 
Adds the "secrets" or environment variables that have been passed into
the component by using the `odo link` feature when connecting to a
database.

Builds upon PR: redhat-developer#2231
Closes: redhat-developer#2232

See the below example of how it now looks like:

```sh
Component Name: nodejs-nodejs-ex-cstb
Type: nodejs
Source: file://./
Environment Variables:
 · foo=bar
 · bar=foo
 · DEBUG_PORT=5858
Storage:
 · mystorage of size 1Gi mounted to /opt/app-root/src/storage/
URLs:
 · http://foobar-app-myproject.192.168.42.79.nip.io exposed via 8080
Linked Components:
 · nodejs2 - Port(s): 8080
Linked Services:
 · mongodb-persistent
   Environment Variables:
    · uri
    · username
    · admin_password
    · database_name
    · password
 · dh-mysql-apb
   Environment Variables:
    · DB_HOST
    · DB_NAME
    · DB_PASSWORD
    · DB_PORT
    · DB_TYPE
    · DB_USER
```
cdrage added a commit to cdrage/odo that referenced this issue Oct 10, 2019
@cdrage
Add secrets to odo describe
f193af5 
Adds the "secrets" or environment variables that have been passed into
the component by using the `odo link` feature when connecting to a
database.

Builds upon PR: redhat-developer#2231
Closes: redhat-developer#2232

See the below example of how it now looks like:

```sh
Component Name: nodejs-nodejs-ex-cstb
Type: nodejs
Source: file://./
Environment Variables:
 · foo=bar
 · bar=foo
 · DEBUG_PORT=5858
Storage:
 · mystorage of size 1Gi mounted to /opt/app-root/src/storage/
URLs:
 · http://foobar-app-myproject.192.168.42.79.nip.io exposed via 8080
Linked Components:
 · nodejs2 - Port(s): 8080
Linked Services:
 · mongodb-persistent
   Environment Variables:
    · uri
    · username
    · admin_password
    · database_name
    · password
 · dh-mysql-apb
   Environment Variables:
    · DB_HOST
    · DB_NAME
    · DB_PASSWORD
    · DB_PORT
    · DB_TYPE
    · DB_USER
```
openshift-merge-robot pushed a commit that referenced this issue Oct 11, 2019
@cdrage @openshift-merge-robot
Add secrets to odo describe (#2233)
97d7ff6 
Adds the "secrets" or environment variables that have been passed into
the component by using the `odo link` feature when connecting to a
database.

Builds upon PR: #2231
Closes: #2232

See the below example of how it now looks like:

```sh
Component Name: nodejs-nodejs-ex-cstb
Type: nodejs
Source: file://./
Environment Variables:
 · foo=bar
 · bar=foo
 · DEBUG_PORT=5858
Storage:
 · mystorage of size 1Gi mounted to /opt/app-root/src/storage/
URLs:
 · http://foobar-app-myproject.192.168.42.79.nip.io exposed via 8080
Linked Components:
 · nodejs2 - Port(s): 8080
Linked Services:
 · mongodb-persistent
   Environment Variables:
    · uri
    · username
    · admin_password
    · database_name
    · password
 · dh-mysql-apb
   Environment Variables:
    · DB_HOST
    · DB_NAME
    · DB_PASSWORD
    · DB_PORT
    · DB_TYPE
    · DB_USER
```
@amitkrout amitkrout mentioned this issue Oct 15, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add secrets to odo describe cdrage/odo
1 participant
@cdrage