Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates odo describe output #2231

Merged
merged 1 commit into from
Oct 7, 2019
Merged

Updates odo describe output #2231

merged 1 commit into from
Oct 7, 2019

Conversation

cdrage
Copy link
Member

@cdrage cdrage commented Oct 2, 2019

Updates the odo describe output to be a bit more intuitive / better
looking.

@cdrage
Updates odo describe output
f8205d4 
Updates the `odo describe` output to be a bit more intuitive / better
looking.
@cdrage
Copy link
Member Author

cdrage commented Oct 2, 2019

See the comparison below:

New

Screenshot from 2019-10-02 15-43-01

Old

Screenshot from 2019-10-02 15-44-15

cdrage added a commit to cdrage/odo that referenced this pull request Oct 2, 2019
@cdrage
Add secrets to odo describe
82d5e7d 
Adds the "secrets" or environment variables that have been passed into
the component by using the `odo link` feature when connecting to a
database.

Builds upon PR: redhat-developer#2231
Closes: redhat-developer#2232

See the below example of how it now looks like:

```sh
Component Name: nodejs-nodejs-ex-cstb
Type: nodejs
Source: file://./
Environment Variables:
 · foo=bar
 · bar=foo
 · DEBUG_PORT=5858
Storage:
 · mystorage of size 1Gi mounted to /opt/app-root/src/storage/
URLs:
 · http://foobar-app-myproject.192.168.42.79.nip.io exposed via 8080
Linked Components:
 · nodejs2 - Port(s): 8080
Linked Services:
 · mongodb-persistent
   Environment Variables:
    · uri
    · username
    · admin_password
    · database_name
    · password
 · dh-mysql-apb
   Environment Variables:
    · DB_HOST
    · DB_NAME
    · DB_PASSWORD
    · DB_PORT
    · DB_TYPE
    · DB_USER
```
@cdrage cdrage mentioned this pull request Oct 2, 2019
Merged
@girishramnani
Copy link
Contributor

Looks the same on windows?

@girishramnani
Copy link
Contributor

as a follow up show we change the output of app describe and catalog describe to the same Bold headers?

@cdrage
Copy link
Member Author

cdrage commented Oct 4, 2019 •
edited

@girishramnani Yes, we should change it in app describe and catalog describe too. But that'll be for a different PR. We should get this one merged in first so we can build upon it.

Yup! Works on Windows.

@girishramnani
Copy link
Contributor

Cool,
/approve

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: girishramnani

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Oct 7, 2019
@girishramnani
Copy link
Contributor

An issue to track the follow up task would be great @cdrage

dharmit
dharmit approved these changes Oct 7, 2019
View reviewed changes
Copy link
Member

@dharmit dharmit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Oct 7, 2019
@openshift-merge-robot openshift-merge-robot merged commit 73a8498 into redhat-developer:master Oct 7, 2019
cdrage added a commit to cdrage/odo that referenced this pull request Oct 7, 2019
@cdrage
Add secrets to odo describe
123d3a4 
Adds the "secrets" or environment variables that have been passed into
the component by using the `odo link` feature when connecting to a
database.

Builds upon PR: redhat-developer#2231
Closes: redhat-developer#2232

See the below example of how it now looks like:

```sh
Component Name: nodejs-nodejs-ex-cstb
Type: nodejs
Source: file://./
Environment Variables:
 · foo=bar
 · bar=foo
 · DEBUG_PORT=5858
Storage:
 · mystorage of size 1Gi mounted to /opt/app-root/src/storage/
URLs:
 · http://foobar-app-myproject.192.168.42.79.nip.io exposed via 8080
Linked Components:
 · nodejs2 - Port(s): 8080
Linked Services:
 · mongodb-persistent
   Environment Variables:
    · uri
    · username
    · admin_password
    · database_name
    · password
 · dh-mysql-apb
   Environment Variables:
    · DB_HOST
    · DB_NAME
    · DB_PASSWORD
    · DB_PORT
    · DB_TYPE
    · DB_USER
```
cdrage added a commit to cdrage/odo that referenced this pull request Oct 10, 2019
@cdrage
Add secrets to odo describe
f193af5 
Adds the "secrets" or environment variables that have been passed into
the component by using the `odo link` feature when connecting to a
database.

Builds upon PR: redhat-developer#2231
Closes: redhat-developer#2232

See the below example of how it now looks like:

```sh
Component Name: nodejs-nodejs-ex-cstb
Type: nodejs
Source: file://./
Environment Variables:
 · foo=bar
 · bar=foo
 · DEBUG_PORT=5858
Storage:
 · mystorage of size 1Gi mounted to /opt/app-root/src/storage/
URLs:
 · http://foobar-app-myproject.192.168.42.79.nip.io exposed via 8080
Linked Components:
 · nodejs2 - Port(s): 8080
Linked Services:
 · mongodb-persistent
   Environment Variables:
    · uri
    · username
    · admin_password
    · database_name
    · password
 · dh-mysql-apb
   Environment Variables:
    · DB_HOST
    · DB_NAME
    · DB_PASSWORD
    · DB_PORT
    · DB_TYPE
    · DB_USER
```
openshift-merge-robot pushed a commit that referenced this pull request Oct 11, 2019
@cdrage @openshift-merge-robot
Add secrets to odo describe (#2233)
97d7ff6 
Adds the "secrets" or environment variables that have been passed into
the component by using the `odo link` feature when connecting to a
database.

Builds upon PR: #2231
Closes: #2232

See the below example of how it now looks like:

```sh
Component Name: nodejs-nodejs-ex-cstb
Type: nodejs
Source: file://./
Environment Variables:
 · foo=bar
 · bar=foo
 · DEBUG_PORT=5858
Storage:
 · mystorage of size 1Gi mounted to /opt/app-root/src/storage/
URLs:
 · http://foobar-app-myproject.192.168.42.79.nip.io exposed via 8080
Linked Components:
 · nodejs2 - Port(s): 8080
Linked Services:
 · mongodb-persistent
   Environment Variables:
    · uri
    · username
    · admin_password
    · database_name
    · password
 · dh-mysql-apb
   Environment Variables:
    · DB_HOST
    · DB_NAME
    · DB_PASSWORD
    · DB_PORT
    · DB_TYPE
    · DB_USER
```
@amitkrout amitkrout mentioned this pull request Oct 15, 2019
Merged
@cdrage cdrage deleted the update-odo-describe branch January 14, 2022 14:57
@rm3l rm3l added the estimated-size/M (10-20) Rough sizing for Epics. About 1 sprint of work for one person label Jun 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dharmit dharmit dharmit approved these changes

@girishramnani girishramnani Awaiting requested review from girishramnani

Assignees

@dharmit dharmit

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. estimated-size/M (10-20) Rough sizing for Epics. About 1 sprint of work for one person lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@cdrage @girishramnani @openshift-ci-robot @dharmit @rm3l @openshift-merge-robot