Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow .devfile.yaml #3126

Closed
maxandersen opened this issue May 8, 2020 · 14 comments · Fixed by #5138
Closed

allow .devfile.yaml #3126

maxandersen opened this issue May 8, 2020 · 14 comments · Fixed by #5138
Assignees
@anandrkskd
Labels
estimated-size/L (20-40) Rough sizing for Epics. About 2 sprints of work for a person. kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation priority/Medium Nice to have issue. Getting it done before priority changes would be great.
Projects
Sprint 209
Milestone
2.4 (planning)

Comments

@maxandersen
Copy link
Contributor

maxandersen commented May 8, 2020 •
edited by girishramnani
Loading

/kind feature

Which functionality do you think we should add?

similar to discussed in eclipse-che/che#14548 it is good when devfile.yaml does not need to be shown by default.

Why is this needed?

to make it easier to add support for odo and che without "polluting" users view.
@openshift-ci-robot openshift-ci-robot added the kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation label May 8, 2020
@girishramnani
Copy link
Contributor

allow .devfile.yaml would mean we have an option to change the default filename by which a devfile is downloaded i.e. devfile.yaml to .devfile.yaml and use that to create a component?

@maxandersen
Copy link
Contributor Author

I don't know how that mechanics work - just that if devfile.yaml are not found and a.devfile.yaml are present then that should be used instead.

@maxandersen maxandersen mentioned this issue Jun 2, 2020
Closed
@sbose78
Copy link
Member

sbose78 commented Jun 7, 2020

@girishramnani , Yes.

@kadel
Copy link
Member

kadel commented Jun 8, 2020

If we start allowing .devfile.yaml then we need to make sure that there is only one devfile present in the directory. If both devfile.yaml and .devfile.yaml are present odo needs to error out.

The problem is described here eclipse-che/che#14548 (comment)

@gorkem
Copy link
Contributor

gorkem commented Aug 5, 2020

FYI eclipse-che/che#17537

@sparkoo sparkoo mentioned this issue Aug 6, 2020
Closed
@kadel
Copy link
Member

kadel commented Aug 6, 2020

/triage ready
/priority medium

@openshift-ci-robot openshift-ci-robot added triage/ready priority/Medium Nice to have issue. Getting it done before priority changes would be great. labels Aug 6, 2020
@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci-robot openshift-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 4, 2020
@serenamarie125 serenamarie125 added this to the 2.3 (planning) milestone Nov 5, 2020
@openshift-bot
Copy link

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci-robot openshift-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Dec 6, 2020
@openshift-bot
Copy link

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

@openshift-ci-robot
Copy link
Collaborator

@openshift-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kadel
Copy link
Member

kadel commented Jan 6, 2021

/reopen
/lifecycle frozen
/remove-lifecycle rotten

This is still valid
devfile/api#61

@openshift-ci-robot
Copy link
Collaborator

@kadel: Reopened this issue.

In response to this:

/reopen
/lifecycle frozen
/remove-lifecycle rotten

This is still valid
devfile/api#61

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. labels Jan 6, 2021
@serenamarie125 serenamarie125 modified the milestones: 2.3 (planning), 2.4 Apr 26, 2021
@dharmit dharmit added this to For Consideration in Sprint 207 via automation Sep 2, 2021
@dharmit
Copy link
Member

dharmit commented Sep 9, 2021

Scope

  • in the code just add an OR condition
  • integration test up to just odo url create would suffice.

@dharmit dharmit added estimated-size/L (20-40) Rough sizing for Epics. About 2 sprints of work for a person. and removed lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. labels Sep 9, 2021
@dharmit dharmit self-assigned this Sep 9, 2021
@dharmit dharmit added this to For Consideration in Sprint 208 via automation Sep 27, 2021
@dharmit
Copy link
Member

dharmit commented Sep 29, 2021

/unassign

/assign @anandrkskd

@openshift-ci openshift-ci bot assigned anandrkskd and unassigned dharmit Sep 29, 2021
@dharmit dharmit moved this from For Consideration to To Do in Sprint 208 Sep 29, 2021
@anandrkskd anandrkskd moved this from To Do to In Progress in Sprint 208 Oct 4, 2021
@anandrkskd anandrkskd mentioned this issue Oct 12, 2021
Merged
4 tasks
@dharmit dharmit removed this from For Consideration in Sprint 207 Oct 16, 2021
@dharmit dharmit added this to For Consideration in Sprint 209 via automation Oct 18, 2021
@dharmit dharmit moved this from For Consideration to For Review in Sprint 209 Oct 18, 2021
@dharmit dharmit removed this from In Progress in Sprint 208 Oct 21, 2021
Sprint 209 automation moved this from For Review to Done Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@anandrkskd anandrkskd

Labels
estimated-size/L (20-40) Rough sizing for Epics. About 2 sprints of work for a person. kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation priority/Medium Nice to have issue. Getting it done before priority changes would be great.
Projects
No open projects
Sprint 209
Done
Milestone
2.4 (planning)
Development

Successfully merging a pull request may close this issue.

allow .devfile.yaml anandrkskd/odo
10 participants
@maxandersen @kadel @gorkem @sbose78 @dharmit @openshift-bot @girishramnani @serenamarie125 @openshift-ci-robot @anandrkskd