-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add step to compress before publishing artifacts to appveyor #1029
add step to compress before publishing artifacts to appveyor #1029
Conversation
Code Climate has analyzed commit f47a5a9 and detected 0 issues on this pull request. View more on Code Climate. |
✅ odo build 500 completed and artifacts can be found here (for commit 59bc265164 by @syamgk) |
appveyor.yml
Outdated
@@ -32,12 +32,19 @@ test_script: | |||
build_script: | |||
- make cross | |||
|
|||
after_build: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't it be better to run this after tests (after_test
)?
Currently, it builds binaries, than gzips it, and then run tests. But gzipping doesn't make sense if tests don't pass.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep, ack!
Codecov Report
@@ Coverage Diff @@
## master #1029 +/- ##
==========================================
- Coverage 46.24% 46.12% -0.12%
==========================================
Files 21 21
Lines 3419 3419
==========================================
- Hits 1581 1577 -4
- Misses 1678 1682 +4
Partials 160 160
Continue to review full report at Codecov.
|
75a2336
to
395240d
Compare
add step to compress before publishing artifacts to appveyor
395240d
to
f47a5a9
Compare
✅ odo build 502 completed and artifacts can be found here (for commit d339dcc294 by @syamgk) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
(will merge when travis is 💚 )
add step to compress before publishing artifacts to appveyor
What is the purpose of this change? What does it change?
to reduce the storage consumption on appveyor
Was the change discussed in an issue?
#1025
How to test changes?
check if artifacts are publishing on appveyor in a compressed form and validate the binaries