Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add step to compress before publishing artifacts to appveyor #1029

Merged
merged 1 commit into from
Nov 22, 2018

Conversation

syamgk
Copy link
Member

@syamgk syamgk commented Nov 22, 2018

add step to compress before publishing artifacts to appveyor

What is the purpose of this change? What does it change?

to reduce the storage consumption on appveyor

Was the change discussed in an issue?

#1025

How to test changes?

check if artifacts are publishing on appveyor in a compressed form and validate the binaries

@syamgk syamgk added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Nov 22, 2018
@codeclimate
Copy link

codeclimate bot commented Nov 22, 2018

Code Climate has analyzed commit f47a5a9 and detected 0 issues on this pull request.

View more on Code Climate.

@AppVeyorBot
Copy link

@syamgk syamgk removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Nov 22, 2018
@syamgk syamgk changed the title [WIP] add step to compress before publishing artifacts to appveyor add step to compress before publishing artifacts to appveyor Nov 22, 2018
appveyor.yml Outdated
@@ -32,12 +32,19 @@ test_script:
build_script:
- make cross

after_build:
Copy link
Member

@kadel kadel Nov 22, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't it be better to run this after tests (after_test)?
Currently, it builds binaries, than gzips it, and then run tests. But gzipping doesn't make sense if tests don't pass.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, ack!

@codecov
Copy link

codecov bot commented Nov 22, 2018

Codecov Report

Merging #1029 into master will decrease coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1029      +/-   ##
==========================================
- Coverage   46.24%   46.12%   -0.12%     
==========================================
  Files          21       21              
  Lines        3419     3419              
==========================================
- Hits         1581     1577       -4     
- Misses       1678     1682       +4     
  Partials      160      160
Impacted Files Coverage Δ
pkg/component/watch.go 69.59% <0%> (-2.71%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b21872d...f47a5a9. Read the comment docs.

add step to compress before publishing artifacts to appveyor
@AppVeyorBot
Copy link

Copy link
Contributor

@surajnarwade surajnarwade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
(will merge when travis is 💚 )

@surajnarwade surajnarwade merged commit e058c76 into redhat-developer:master Nov 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants