Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ComponentTypeList should be List in machine output #2230

Merged
merged 1 commit into from
Oct 7, 2019
Merged

ComponentTypeList should be List in machine output #2230

merged 1 commit into from
Oct 7, 2019

Conversation

cdrage
Copy link
Member

@cdrage cdrage commented Oct 2, 2019

For odo catalog list components machine-readable output for Kind
should simply be List

@cdrage
ComponentTypeList should be List in machine output
a3187dc 
For `odo catalog list components` machine-readable output for `Kind`
should simply be `List`
@cdrage
Copy link
Member Author

cdrage commented Oct 2, 2019

/retest

@dharmit
Copy link
Member

dharmit commented Oct 7, 2019 •
edited

@cdrage don't we have tests that check for the json output of odo catalog list -o json? Should we not have it?

cc @amitkrout

UPDATE: We do have tests for ServiceTypeList #2229. I think we should add for ComponentTypeList as well. 😄

@amitkrout
Copy link
Contributor

@cdrage don't we have tests that check for the json output of odo catalog list -o json? Should we not have it?

cc @amitkrout

UPDATE: We do have tests for ServiceTypeList #2229. I think we should add for ComponentTypeList as well. 😄

Test has been updated for this pr - https://github.com/openshift/odo/pull/2230/files#diff-f0f2e54d32d2c1ab57020c3a3dd9a3fbR197.

/approve
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Oct 7, 2019
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: amitkrout

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Oct 7, 2019
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 78a1a88 into redhat-developer:master Oct 7, 2019
@amitkrout amitkrout mentioned this pull request Oct 15, 2019
Merged
@cdrage cdrage deleted the update-catalogcomponentlist branch January 14, 2022 14:56
@rm3l rm3l added the estimated-size/XS (1-5) Rough sizing for Epics. Less than one sprint of work for one person, but smaller than S. label Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amitkrout amitkrout Awaiting requested review from amitkrout

@dharmit dharmit Awaiting requested review from dharmit

Assignees

@amitkrout amitkrout

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. estimated-size/XS (1-5) Rough sizing for Epics. Less than one sprint of work for one person, but smaller than S. lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@cdrage @dharmit @amitkrout @openshift-ci-robot @openshift-bot @rm3l @openshift-merge-robot