-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update s2i to devfile conversion as per new url design #3930
update s2i to devfile conversion as per new url design #3930
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3930 +/- ##
==========================================
+ Coverage 44.78% 44.82% +0.04%
==========================================
Files 143 143
Lines 13911 13898 -13
==========================================
Hits 6230 6230
+ Misses 7089 7076 -13
Partials 592 592
Continue to review full report at Codecov.
|
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: girishramnani The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
works good!
/lgtm
What type of PR is this?
/kind bug
What does does this PR do / why we need it:
update s2i to devfile conversion to not save url info in env.yaml.
Which issue(s) this PR fixes:
Fixes #3910
PR acceptance criteria:
Unit test
Integration test
Documentation (not needed)
I have read the test guidelines
How to test changes / Special notes to the reviewer: