Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update s2i to devfile conversion as per new url design #3930

Merged

Conversation

adisky
Copy link
Contributor

@adisky adisky commented Sep 10, 2020

What type of PR is this?
/kind bug

What does does this PR do / why we need it:
update s2i to devfile conversion to not save url info in env.yaml.

Which issue(s) this PR fixes:

Fixes #3910

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation (not needed)

  • I have read the test guidelines

How to test changes / Special notes to the reviewer:

@adisky adisky changed the title update s2i to devfile conversion a per new design update s2i to devfile conversion as per new design Sep 10, 2020
@adisky adisky changed the title update s2i to devfile conversion as per new design update s2i to devfile conversion as per new url design Sep 10, 2020
@adisky adisky added area/regression kind/bug Categorizes issue or PR as related to a bug. labels Sep 10, 2020
@codecov
Copy link

codecov bot commented Sep 10, 2020

Codecov Report

Merging #3930 into master will increase coverage by 0.04%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3930      +/-   ##
==========================================
+ Coverage   44.78%   44.82%   +0.04%     
==========================================
  Files         143      143              
  Lines       13911    13898      -13     
==========================================
  Hits         6230     6230              
+ Misses       7089     7076      -13     
  Partials      592      592              
Impacted Files Coverage Δ
pkg/odo/cli/utils/convert.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c9fbdb...b2687c6. Read the comment docs.

@girishramnani
Copy link
Contributor

/approve

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: girishramnani

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Sep 16, 2020
Copy link
Contributor

@maysunfaisal maysunfaisal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works good!

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Sep 16, 2020
@openshift-merge-robot openshift-merge-robot merged commit f8c3ada into redhat-developer:master Sep 17, 2020
@rm3l rm3l added the v2 Issue or PR that applies to the v2 of odo label Jun 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. Required by Prow. v2 Issue or PR that applies to the v2 of odo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

converting s2i items to devfile items does not set the Endpoint's name properly
6 participants