3923- url creation with optional port flag #3950

yangcao77 · 2020-09-14T19:16:08Z

What type of PR is this?

/kind bug
/area devfile
/area url

What does does this PR do / why we need it:
The --port flag should be an optional flag if there is only one port exposed in devfile.
This PR fixes the regression.

Also created an integration test for the specific case

Which issue(s) this PR fixes:

Fixes #3923

PR acceptance criteria:

Unit test
Integration test
Documentation
I have read the test guidelines

How to test changes / Special notes to the reviewer:
make test-cmd-devfile-url

Manual Test:
odo url create should successfully create an endpoint in devfile

Signed-off-by: Stephanie <yangcao@redhat.com>

mik-dass · 2020-09-15T07:08:27Z

tests/integration/devfile/cmd_devfile_url_test.go

+			helper.CopyExample(filepath.Join("source", "devfiles", "nodejs", "project"), context)
+			helper.CopyExampleDevFile(filepath.Join("source", "devfiles", "nodejs", "devfile.yaml"), filepath.Join(context, "devfile.yaml"))
+
+			helper.CmdShouldPass("odo", "url", "create", url1, "--host", host, "--secure", "--ingress")


please add a check to verify that the default port was added to the devfile. We can check the devfile.yaml or use odo url list.

codecov · 2020-09-15T10:16:00Z

Codecov Report

Merging #3950 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3950   +/-   ##
=======================================
  Coverage   44.60%   44.60%           
=======================================
  Files         143      143           
  Lines       14000    14000           
=======================================
  Hits         6244     6244           
  Misses       7164     7164           
  Partials      592      592

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b055c99...4d86553. Read the comment docs.

Signed-off-by: Stephanie <yangcao@redhat.com>

mik-dass · 2020-09-16T06:01:23Z

tests/integration/devfile/cmd_devfile_url_test.go

+
+			helper.CmdShouldPass("odo", "url", "create", url1, "--host", host, "--ingress")
+			stdout := helper.CmdShouldPass("odo", "url", "list")
+			helper.MatchAllInOutput(stdout, []string{url1, "Not Pushed"})


Please also check the port number in the output

…onWithoptionalPort

Signed-off-by: Stephanie <yangcao@redhat.com>

yangcao77 · 2020-09-16T13:46:40Z

/retest

mik-dass

/lgtm

mik-dass · 2020-09-17T05:18:07Z

error: some steps failed:
  * could not run steps: execution cancelled
time="2020-09-16T17:52:27Z" level=info msg="Reporting job state 'failed' with reason 'executing_graph:interrupted'"
{"component":"entrypoint","file":"prow/entrypoint/run.go:247","func":"k8s.io/test-infra/prow/entrypoint.gracefullyTerminate","level":"error","msg":"Process gracefully exited before 30m0s grace period","severity":"error","time":"2020-09-16T17:52:27Z"}

/retest

girishramnani · 2020-09-17T09:22:16Z

/approve

openshift-ci-robot · 2020-09-17T09:22:34Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: girishramnani

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [girishramnani]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2020-09-17T16:44:34Z

/retest