Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document odo and Operator Hub integration #3982

Merged
merged 1 commit into from
Sep 22, 2020
Merged

Document odo and Operator Hub integration #3982

merged 1 commit into from
Sep 22, 2020

Conversation

dharmit
Copy link
Member

@dharmit dharmit commented Sep 18, 2020

What type of PR is this?
/kind documentation
[skip ci]

What does this PR do / why we need it:
Adds more documentation for Operator Hub integration with odo

Which issue(s) this PR fixes:

Fixes #3810

PR acceptance criteria:

How to test changes / Special notes to the reviewer:
Read the docs!

@girishramnani
Copy link
Contributor

/retest

@dharmit
Copy link
Member Author

dharmit commented Sep 21, 2020

/retest

Why does this even require tests? 😞 I've specified skip ci in the commit message and PR description. Only mistake I made was to write skip-ci instead of skip ci in the commit message. I changed that and force pushed it. But still it goes through unnecessary CI cycles.

@girishramnani
Copy link
Contributor

/approve

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: girishramnani

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Sep 21, 2020
@cdrage
Copy link
Member

cdrage commented Sep 22, 2020

/lgtm

@cdrage cdrage merged commit b3c126d into redhat-developer:master Sep 22, 2020
@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Sep 22, 2020
@dharmit dharmit deleted the fix-3810 branch January 7, 2021 03:48
@rm3l rm3l added the v2 Issue or PR that applies to the v2 of odo label Jun 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. lgtm Indicates that a PR is ready to be merged. Required by Prow. v2 Issue or PR that applies to the v2 of odo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation for Operator Hub integration in v2
5 participants