Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate layers : Preference #5296

Merged
merged 11 commits into from
Jan 10, 2022
Merged

Separate layers : Preference #5296

merged 11 commits into from
Jan 10, 2022

Commits on Jan 10, 2022

  1. Refactor preference package

    @feloy
    feloy committed Jan 10, 2022
    Configuration menu
    Copy the full SHA
    f4543d8 View commit details
    Browse the repository at this point in the history

  2. Unit tests

    @feloy
    feloy committed Jan 10, 2022
    Configuration menu
    Copy the full SHA
    ccdc84b View commit details
    Browse the repository at this point in the history

  3. Apply suggestions from code review 

    Co-authored-by: Parthvi Vala <pvala@redhat.com>
    @feloy @valaparthvi
    feloy and valaparthvi committed Jan 10, 2022
    Configuration menu
    Copy the full SHA
    58b3862 View commit details
    Browse the repository at this point in the history

  4. Review

    @feloy
    feloy committed Jan 10, 2022
    Configuration menu
    Copy the full SHA
    4b6121f View commit details
    Browse the repository at this point in the history

  5. Review from Dharmit

    @feloy
    feloy committed Jan 10, 2022
    Configuration menu
    Copy the full SHA
    2113abd View commit details
    Browse the repository at this point in the history

  6. Replace panic with LogErrorAndExit

    @feloy
    feloy committed Jan 10, 2022
    Configuration menu
    Copy the full SHA
    e8b4160 View commit details
    Browse the repository at this point in the history

  7. Remove preference from kclient/oc_server

    @feloy
    feloy committed Jan 10, 2022
    Configuration menu
    Copy the full SHA
    d9e1bd5 View commit details
    Browse the repository at this point in the history

  8. Remove preference.New from devfile

    @feloy
    feloy committed Jan 10, 2022
    Configuration menu
    Copy the full SHA
    0b8bf14 View commit details
    Browse the repository at this point in the history

  9. Remove preference.New from kclient/WaitAndGetPodWithEvents

    @feloy
    feloy committed Jan 10, 2022
    Configuration menu
    Copy the full SHA
    f6f3117 View commit details
    Browse the repository at this point in the history

  10. Get prefClient from CreateOptions

    @feloy
    feloy committed Jan 10, 2022
    Configuration menu
    Copy the full SHA
    76d3663 View commit details
    Browse the repository at this point in the history

  11. Parthvi review

    @feloy
    feloy committed Jan 10, 2022
    Configuration menu
    Copy the full SHA
    2bfa3da View commit details
    Browse the repository at this point in the history