Make 3.0.0 the default on the site #5857
Conversation
✅ Deploy Preview for odo-docusaurus-preview ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
cdrage
force-pushed
the
make-3.0.0-default
branch
from
bfaaef5
to
1eb0c3e
Compare
|
/approve All the updated links are in place. |
openshift-ci
bot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: valaparthvi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
|
/cancel lgtm |
valaparthvi
removed
the
lgtm
|
/hold cancel
|
valaparthvi
removed
the
do-not-merge/hold
|
The text in the top banner seems a bit repetitive to me when we are browsing the 3.0.0 docs, especially the last sentence: |
I think the last sentence is supposed to talk about the stable 2.5.0 version, I remember seeing it somewhere. |
Clear your cookies :) probably why it was doing that. |
cdrage
force-pushed
the
make-3.0.0-default
branch
from
1eb0c3e
to
d47fcd8
Compare
I've removed these! :) it shouldn't appear anymore and instead use the 🚧 emoji and that it's "alpha" to indicate it's unreleased. |
openshift-ci
bot
added
the
lgtm
<!-- Thank you for opening a PR! Here are some things you need to know before submitting: 1. Please read our developer guideline: https://github.com/redhat-developer/odo/wiki/Dev:-odo-Dev-Guidelines 2. Label this PR accordingly with the '/kind' line 3. Ensure you have written and ran the appropriate tests: https://github.com/redhat-developer/odo/wiki/Dev:-Writing-and-running-tests 4. Read how we approve and LGTM each PR: https://github.com/redhat-developer/odo/wiki/Pull-Requests:-Review-guideline Documentation: If you are pushing a change to documentation, please read: https://github.com/redhat-developer/odo/wiki/Documentation:-Contributing --> **What type of PR is this:** <!-- Add one of the following kinds: /kind bug /kind feature /kind cleanup /kind tests Feel free to use other [labels](https://github.com/redhat-developer/odo/labels) as needed. However one of the above labels must be present or the PR will not be reviewed. This instruction is for reviewers as well. --> /kind documentation **What does this PR do / why we need it:** * Moves the 3.0.0 documentation to current * Changes the "intro" page to "introduction" due to limitations of docusaurus index paging. **Which issue(s) this PR fixes:** <!-- Specifying the issue will automatically close it when this PR is merged --> Fixes redhat-developer#5842 **PR acceptance criteria:** - [X] Documentation **How to test changes / Special notes to the reviewer:** Signed-off-by: Charlie Drage <charlie@charliedrage.com>
cdrage
force-pushed
the
make-3.0.0-default
branch
from
d47fcd8
to
9ae352d
Compare
openshift-ci
bot
removed
the
lgtm
|
Fixed and ready for another review 👍 |
|
Kudos, SonarCloud Quality Gate passed!
|
openshift-ci
bot
added
the
lgtm
|
Let's merge this in! Got one approval for docs (that's only what's needed). We can see what issues arise this week with broken links, but I've covered all use cases for the README.md as well as wiki + main page (no docusaurus errors) |
* Make 3.0.0 the default on the site <!-- Thank you for opening a PR! Here are some things you need to know before submitting: 1. Please read our developer guideline: https://github.com/redhat-developer/odo/wiki/Dev:-odo-Dev-Guidelines 2. Label this PR accordingly with the '/kind' line 3. Ensure you have written and ran the appropriate tests: https://github.com/redhat-developer/odo/wiki/Dev:-Writing-and-running-tests 4. Read how we approve and LGTM each PR: https://github.com/redhat-developer/odo/wiki/Pull-Requests:-Review-guideline Documentation: If you are pushing a change to documentation, please read: https://github.com/redhat-developer/odo/wiki/Documentation:-Contributing --> **What type of PR is this:** <!-- Add one of the following kinds: /kind bug /kind feature /kind cleanup /kind tests Feel free to use other [labels](https://github.com/redhat-developer/odo/labels) as needed. However one of the above labels must be present or the PR will not be reviewed. This instruction is for reviewers as well. --> /kind documentation **What does this PR do / why we need it:** * Moves the 3.0.0 documentation to current * Changes the "intro" page to "introduction" due to limitations of docusaurus index paging. **Which issue(s) this PR fixes:** <!-- Specifying the issue will automatically close it when this PR is merged --> Fixes redhat-developer#5842 **PR acceptance criteria:** - [X] Documentation **How to test changes / Special notes to the reviewer:** Signed-off-by: Charlie Drage <charlie@charliedrage.com> * fix broken links * fix more links
What type of PR is this:
/kind documentation
What does this PR do / why we need it:
docusaurus index paging.
Which issue(s) this PR fixes:
Fixes #5842
PR acceptance criteria:
How to test changes / Special notes to the reviewer:
Signed-off-by: Charlie Drage charlie@charliedrage.com