Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove localconfigLocalConfigProvider abstraction #6285

Merged
merged 3 commits into from
Nov 16, 2022
Merged

Remove localconfigLocalConfigProvider abstraction #6285

merged 3 commits into from
Nov 16, 2022

Conversation

feloy
Copy link
Contributor

@feloy feloy commented Nov 4, 2022

What type of PR is this:

/kind code-refactoring

What does this PR do / why we need it:

This refactoring is useful for being able to work with Storage without unnecessary localconfigLocalConfigProvider abstraction

@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. kind/code-refactoring labels Nov 4, 2022
@netlify
Copy link

netlify bot commented Nov 4, 2022 •
edited
Loading

✅ Deploy Preview for odo-docusaurus-preview canceled.

Name Link
🔨 Latest commit 5fc198f
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/636bcf5531c470000802d2a1

@odo-robot
Copy link

odo-robot bot commented Nov 4, 2022 •
edited
Loading

NoCluster Tests on commit d5b4f7e finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Nov 4, 2022 •
edited
Loading

Unit Tests on commit d5b4f7e finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Nov 4, 2022 •
edited
Loading

Validate Tests on commit d5b4f7e finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Nov 4, 2022 •
edited
Loading

Windows Tests (OCP) on commit d5b4f7e finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Nov 4, 2022 •
edited
Loading

Kubernetes Tests on commit d5b4f7e finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Nov 4, 2022 •
edited
Loading

OpenShift Tests on commit d5b4f7e finished successfully.
View logs: TXT HTML

@feloy feloy changed the title [WIP] Remove localconfigLocalConfigProvider abstraction Remove localconfigLocalConfigProvider abstraction Nov 4, 2022
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Nov 4, 2022
@feloy feloy added the area/odo-on-podman Issues or PRs related to running odo against Podman label Nov 4, 2022
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Nov 8, 2022
@rm3l rm3l added this to the v3.3.0 🚀 milestone Nov 9, 2022
@feloy feloy force-pushed the refacto/remove-local-config-abstraction branch from 59f0627 to 5fc198f Compare November 9, 2022 16:03
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Nov 9, 2022
@feloy
Copy link
Contributor Author

feloy commented Nov 9, 2022

Rebased on main to use go v1.18

@feloy feloy requested a review from rm3l November 10, 2022 07:54
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Nov 10, 2022
@rm3l rm3l closed this Nov 10, 2022
@rm3l rm3l reopened this Nov 10, 2022
@rm3l
Copy link
Member

rm3l commented Nov 10, 2022 

unable to download starter project "nodejs-starter": Get "https://github.com/odo-devfiles/nodejs-ex.git/info/refs?service=git-upload-pack": net/http: TLS handshake timeout

Let's retrigger the tests.

@sonarcloud
Copy link

sonarcloud bot commented Nov 10, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@rm3l
Copy link
Member

rm3l commented Nov 16, 2022

/test v4.11-integration-e2e

rm3l
rm3l reviewed Nov 16, 2022
View reviewed changes
Copy link
Member

@rm3l rm3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci
Copy link

openshift-ci bot commented Nov 16, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rm3l

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Nov 16, 2022
@openshift-merge-robot openshift-merge-robot merged commit 67272fd into redhat-developer:main Nov 16, 2022
@rm3l rm3l added the area/refactoring Issues or PRs related to code refactoring label Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rm3l rm3l rm3l approved these changes

@valaparthvi valaparthvi Awaiting requested review from valaparthvi

Assignees

@rm3l rm3l

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. area/odo-on-podman Issues or PRs related to running odo against Podman area/refactoring Issues or PRs related to code refactoring lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Milestone
v3.3.0 🚀
Development

Successfully merging this pull request may close these issues.
3 participants
@feloy @rm3l @openshift-merge-robot