New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Go: Bump github.com/mattn/go-colorable from 0.1.9 to 0.1.13 #6321
Go: Bump github.com/mattn/go-colorable from 0.1.9 to 0.1.13 #6321
Conversation
Bumps [github.com/mattn/go-colorable](https://github.com/mattn/go-colorable) from 0.1.9 to 0.1.13. - [Release notes](https://github.com/mattn/go-colorable/releases) - [Commits](mattn/go-colorable@v0.1.9...v0.1.13) --- updated-dependencies: - dependency-name: github.com/mattn/go-colorable dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
✅ Deploy Preview for odo-docusaurus-preview ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Hi @dependabot[bot]. Thanks for your PR. I'm waiting for a redhat-developer member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/hold
Since github.com/mattn/go-colorable is a colorable writer for Windows, we need to check the behavior on Windows.
Just confirmed that colorable output is still working on Windows. /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rm3l The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test unit-and-validate-test |
/override ci/prow/unit-and-validate-test |
@valaparthvi: Overrode contexts on behalf of valaparthvi: ci/prow/unit-and-validate-test In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The issue reported on Prow seems relevant to me and worth looking into, IMO. |
…ush' 'GetKubernetesComponentsToPush' internally iterates over a map to return the resulting slice, but the iteration order of a Map in Go is not guaranteed.
Thanks for the fix on unit tests |
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
/override ci/prow/v4.11-integration-e2e |
@feloy: Overrode contexts on behalf of feloy: ci/prow/v4.11-integration-e2e In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Bumps github.com/mattn/go-colorable from 0.1.9 to 0.1.13.
Commits
11a925c
update dependenciese1bb79c
Merge pull request #63 from naoyukis/delete_buf699629e
delete bufa1c5ae5
Merge pull request #62 from tklauser/fix-go-version-gh-action77502a5
Update dependenciesf2a4b66
Use correct field to specify Go version in GitHub action797e0c2
Merge pull request #61 from tklauser/gh-actionsb004592
Migrate to GitHub actions for CI testing6a118b2
Merge pull request #56 from secDre4mer/mastera53eda5
Merge pull request #59 from tklauser/go-build-linesDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)