Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go: Bump github.com/mattn/go-colorable from 0.1.9 to 0.1.13 #6321

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Nov 21, 2022

Bumps github.com/mattn/go-colorable from 0.1.9 to 0.1.13.

Commits
  • 11a925c update dependencies
  • e1bb79c Merge pull request #63 from naoyukis/delete_buf
  • 699629e delete buf
  • a1c5ae5 Merge pull request #62 from tklauser/fix-go-version-gh-action
  • 77502a5 Update dependencies
  • f2a4b66 Use correct field to specify Go version in GitHub action
  • 797e0c2 Merge pull request #61 from tklauser/gh-actions
  • b004592 Migrate to GitHub actions for CI testing
  • 6a118b2 Merge pull request #56 from secDre4mer/master
  • a53eda5 Merge pull request #59 from tklauser/go-build-lines
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [github.com/mattn/go-colorable](https://github.com/mattn/go-colorable) from 0.1.9 to 0.1.13.
- [Release notes](https://github.com/mattn/go-colorable/releases)
- [Commits](mattn/go-colorable@v0.1.9...v0.1.13)

---
updated-dependencies:
- dependency-name: github.com/mattn/go-colorable
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added area/dependency Issues or PRs related to dependency changes. This label is also used on all Dependabot PRs do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. Required by Prow. kind/task Issue is actionable task ok-to-test Indicates a non-member PR verified by an org member that is safe to test. labels Nov 21, 2022
@dependabot dependabot bot requested a review from a team November 21, 2022 02:26
@netlify
Copy link

netlify bot commented Nov 21, 2022

Deploy Preview for odo-docusaurus-preview ready!

Name Link
🔨 Latest commit 0c784bb
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/637b94d4760b010009d7adcb
😎 Deploy Preview https://deploy-preview-6321--odo-docusaurus-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@openshift-ci
Copy link

openshift-ci bot commented Nov 21, 2022

Hi @dependabot[bot]. Thanks for your PR.

I'm waiting for a redhat-developer member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@odo-robot
Copy link

odo-robot bot commented Nov 21, 2022

NoCluster Tests on commit 9ffe95e finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Nov 21, 2022

Unit Tests on commit 9ffe95e finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Nov 21, 2022

Validate Tests on commit 9ffe95e finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Nov 21, 2022

Windows Tests (OCP) on commit 9ffe95e finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Nov 21, 2022

Kubernetes Tests on commit 9ffe95e finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Nov 21, 2022

OpenShift Tests on commit 9ffe95e finished successfully.
View logs: TXT HTML

Copy link
Member

@rm3l rm3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold

Since github.com/mattn/go-colorable is a colorable writer for Windows, we need to check the behavior on Windows.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Nov 21, 2022
@rm3l
Copy link
Member

rm3l commented Nov 21, 2022

Just confirmed that colorable output is still working on Windows.

/approve
/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. Required by Prow. label Nov 21, 2022
@openshift-ci
Copy link

openshift-ci bot commented Nov 21, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rm3l

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Nov 21, 2022
@rm3l
Copy link
Member

rm3l commented Nov 21, 2022

/test unit-and-validate-test

@valaparthvi
Copy link
Member

/override ci/prow/unit-and-validate-test
IBM unit and validate tests pass.

@openshift-ci
Copy link

openshift-ci bot commented Nov 21, 2022

@valaparthvi: Overrode contexts on behalf of valaparthvi: ci/prow/unit-and-validate-test

In response to this:

/override ci/prow/unit-and-validate-test
IBM unit and validate tests pass.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dharmit dharmit removed their request for review November 21, 2022 12:25
@rm3l
Copy link
Member

rm3l commented Nov 21, 2022

--- FAIL: TestGetKubernetesComponentsToPush (0.00s)
    --- FAIL: TestGetKubernetesComponentsToPush/allow_component_referenced_by_apply_command_when_allowApply_is_true (0.00s)
        components_test.go:170: 
            Got      [{Name:component2 Attributes:map[] ComponentUnion:{ComponentType: Container:<nil> Kubernetes:0xc000116a00 Openshift:<nil> Volume:<nil> Image:<nil> Plugin:<nil> Custom:<nil>}} {Name:component1 Attributes:map[] ComponentUnion:{ComponentType: Container:<nil> Kubernetes:0xc0001169b0 Openshift:<nil> Volume:<nil> Image:<nil> Plugin:<nil> Custom:<nil>}}]
            Expected [{Name:component1 Attributes:map[] ComponentUnion:{ComponentType: Container:<nil> Kubernetes:0xc000116b90 Openshift:<nil> Volume:<nil> Image:<nil> Plugin:<nil> Custom:<nil>}} {Name:component2 Attributes:map[] ComponentUnion:{ComponentType: Container:<nil> Kubernetes:0xc000116be0 Openshift:<nil> Volume:<nil> Image:<nil> Plugin:<nil> Custom:<nil>}}]
FAIL

The issue reported on Prow seems relevant to me and worth looking into, IMO.
It looks like we are expecting a slice with a given order, but the GetKubernetesComponentsToPush function we are calling is internally iterating over a map to populate the resulting slice. But the iteration order of maps is not guaranteed in Go.

…ush'

'GetKubernetesComponentsToPush' internally iterates over a map to return
the resulting slice, but the iteration order of a Map in Go is not guaranteed.
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Nov 21, 2022
@feloy
Copy link
Contributor

feloy commented Nov 21, 2022

Thanks for the fix on unit tests
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Nov 21, 2022
@feloy feloy closed this Nov 21, 2022
@feloy feloy reopened this Nov 21, 2022
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Nov 21, 2022

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@rm3l rm3l closed this Nov 21, 2022
@rm3l rm3l reopened this Nov 21, 2022
@sonarcloud
Copy link

sonarcloud bot commented Nov 21, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@feloy
Copy link
Contributor

feloy commented Nov 21, 2022

/override ci/prow/v4.11-integration-e2e
1 flaky test
Pass on IBM Cloud

@openshift-ci
Copy link

openshift-ci bot commented Nov 21, 2022

@feloy: Overrode contexts on behalf of feloy: ci/prow/v4.11-integration-e2e

In response to this:

/override ci/prow/v4.11-integration-e2e
1 flaky test
Pass on IBM Cloud

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit b581f9d into main Nov 21, 2022
@dependabot dependabot bot deleted the dependabot/go_modules/github.com/mattn/go-colorable-0.1.13 branch November 21, 2022 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. area/dependency Issues or PRs related to dependency changes. This label is also used on all Dependabot PRs kind/task Issue is actionable task lgtm Indicates that a PR is ready to be merged. Required by Prow. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants