Add support for parsing multiple k8s definition in a single Devfile K8s component #6372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
kind/feature
✅ Deploy Preview for odo-docusaurus-preview canceled.
|
valaparthvi
force-pushed
the
6275-support-for-multiple-k8s-definition
branch
from
847f18e
to
eec32f0
Compare
|
/retest |
feloy
suggested changes
Dec 6, 2022
| if err != nil { | ||
| continue | ||
| } | ||
| // We default to the first object in the list because as far as ServiceBinding is concerned, | ||
| // we assume that only one resource will be defined for the Devfile K8s component; which is true | ||
| unstructuredObj := unstructuredObjs[0] |
There was a problem hiding this comment.
Please check that len(unstructuredObjs) > 0 before, or this will panic
There was a problem hiding this comment.
I think it's unlikely that the list will ever be empty. I've tried to run the remove binding command on non-existent bindings and it's never panicked. But you're right, I'll add the check to be on the safe side.
There was a problem hiding this comment.
One should never under-estimate the imagination of users ...
…ariablesSubstituted
…ests in a single k8s component Signed-off-by: Parthvi Vala <pvala@redhat.com>
…component/adapter.go
…tK8sComponentAsUnstructured
…ed for the component
Signed-off-by: Parthvi Vala <pvala@redhat.com>
Signed-off-by: Parthvi Vala <pvala@redhat.com>
valaparthvi
force-pushed
the
6275-support-for-multiple-k8s-definition
branch
from
eec32f0
to
c332ad5
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
feloy
approved these changes
Dec 7, 2022
openshift-ci
bot
added
the
lgtm
27 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this:
/kind feature
What does this PR do / why we need it:
This PR adds support for parsing multiple k8s resources defined inside a single yaml against a Devfile K8s component.
Which issue(s) this PR fixes:
Fixes #6275
PR acceptance criteria:
Unit test
Integration test
Documentation
How to test changes / Special notes to the reviewer: