Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not return an error in odo analyze if current directory contains an invalid Devfile #6905

Merged
merged 5 commits into from
Jun 22, 2023
Merged

Do not return an error in odo analyze if current directory contains an invalid Devfile #6905

merged 5 commits into from
Jun 22, 2023

Commits on Jun 21, 2023

  1. Add unit test highliging the issue

    @rm3l
    rm3l committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    a96748b View commit details
    Browse the repository at this point in the history

  2. Fix 'delete' unit tests

    @rm3l
    rm3l committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    2d637f7 View commit details
    Browse the repository at this point in the history

  3. Pass the filesystem object where it is relevant

    @rm3l
    rm3l committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    c6eaaf7 View commit details
    Browse the repository at this point in the history

  4. Add a way for CLI commands to indicate whether of not they require a … 

    …valid Devfile

For the 'analyze' command, this is not required,
so Devfile parsing will be ignored completely.
    @rm3l
    rm3l committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    be30876 View commit details
    Browse the repository at this point in the history

  5. Make the fake filesystem return an absolute current dir 

    Otherwise, some code will assume it is relative,
and try to prepend the current physical directory
    @rm3l
    rm3l committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    e93f48f View commit details
    Browse the repository at this point in the history