Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes Why Did We Create Odo and cleans up README #930

Merged
merged 1 commit into from
Nov 7, 2018

Conversation

cdrage
Copy link
Member

@cdrage cdrage commented Nov 5, 2018

Removes the "Why Did we Create Odo" section and cleans up the README so
it's more concise / smaller.

I believe that there's too much text and multiple paragraphs that iterate
over the same concept (Odo is fast, it reduces development time, etc.).

Having a few sentences / list of features is more than enough.

@codeclimate
Copy link

codeclimate bot commented Nov 5, 2018

Code Climate has analyzed commit dcb89f8 and detected 0 issues on this pull request.

View more on Code Climate.

@AppVeyorBot
Copy link

README.md Outdated

OpenShift Do (Odo) is a CLI tool for developers who are writing, building, and deploying applications on OpenShift. With Odo, developers get an opinionated CLI tool that supports fast, iterative development which abstracts away Kubernetes and OpenShift concepts, thus allowing them to focus on what's most important to them: code.

Odo was created to improve the developer experience with OpenShift. Existing tools such as `oc` are more operations-focused and requires a depp-understanding of Kubernetes and OpenShift concepts. Odo is designed to be simple and concise so you may focus on coding rather than how to deploy your application. Since Odo can build and deploy your code to your cluster immediately after you save you changes, you benefit from instant feedback and can thus validate your changes in real-time.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: depp->deep. Also I don't think that deep understanding is hyphenated.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would still mention odo core concepts here (project, application, components).

README.md Outdated

Odo is *not* a replacement for the standard `oc` CLI tool, and it is not intended to be used by operations, security, or release management teams.
- Designed for fast, iterative developmeny cycles
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

developmeny -> development

README.md Outdated

Odo is *not* a replacement for the standard `oc` CLI tool, and it is not intended to be used by operations, security, or release management teams.
- Designed for fast, iterative developmeny cycles
- No server needed. 100% OpenShift API communication
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not clear.

README.md Outdated
- Supports multiple languages and frameworks such as Node.js, Java, Ruby, Perl, PHP and Python
- Detect changes to your local code and deploy automatically with `odo watch`
- List all available components and services from your OpenShift cluster
- Support for linking and multiple deployments
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not clear. Also not a fan of feature list because they tend to get outdated.

Removes the "Why Did we Create Odo" section and cleans up the README so
it's more concise / smaller.

I believe that there's *too much* text and multiple paragraphs that iterate
over the same concept (Odo is fast, it reduces development time, etc.).

Having a few sentences / list of features is more than enough.
@codecov
Copy link

codecov bot commented Nov 6, 2018

Codecov Report

Merging #930 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #930   +/-   ##
=======================================
  Coverage   46.53%   46.53%           
=======================================
  Files          18       18           
  Lines        2933     2933           
=======================================
  Hits         1365     1365           
  Misses       1423     1423           
  Partials      145      145

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56ecc24...dcb89f8. Read the comment docs.

@cdrage
Copy link
Member Author

cdrage commented Nov 6, 2018

@metacosm Updated the README to address your comments 👍

@metacosm
Copy link
Contributor

metacosm commented Nov 6, 2018

@cdrage did you force push? The UI fails to show updates. Looking at the files directly, LGTM, though.

@cdrage cdrage merged commit 7f1251b into redhat-developer:master Nov 7, 2018
cdrage added a commit to cdrage/odo that referenced this pull request Nov 9, 2018
)

Removes the "Why Did we Create Odo" section and cleans up the README so
it's more concise / smaller.

I believe that there's *too much* text and multiple paragraphs that iterate
over the same concept (Odo is fast, it reduces development time, etc.).

Having a few sentences / list of features is more than enough.
@cdrage cdrage deleted the update-readme-a-bit branch January 14, 2022 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants