Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve memory and peformance of Qute LS #654

Closed
angelozerr opened this issue Jun 8, 2022 · 3 comments · Fixed by #659
Closed

Improve memory and peformance of Qute LS #654

angelozerr opened this issue Jun 8, 2022 · 3 comments · Fixed by #659
Assignees
@datho7561
Labels
enhancement New feature or request performance
Milestone
v0.12.0

Comments

@angelozerr
Copy link
Contributor

angelozerr commented Jun 8, 2022 •
edited

Like LemMinx
@datho7561 datho7561 linked a pull request Jun 28, 2022 that will close this issue
Delay revalidation after edit and improve cancel checking #659
Merged
@datho7561 datho7561 added enhancement New feature or request performance labels Jun 28, 2022
@datho7561 datho7561 added this to the v0.12.0 milestone Jun 28, 2022
@datho7561
Copy link
Contributor

Hey Angelo. Am I okay to close this issue? I think this has been addressed by #659

@datho7561 datho7561 self-assigned this Jun 28, 2022
@angelozerr
Copy link
Contributor Author

@datho7561 I add the missing issue eclipse/lemminx#1206 It should be nice if you could work on it. It's not a big deal. It avoids creating a lot of int array each time the template must be parsed.

datho7561 added a commit to datho7561/quarkus-ls that referenced this issue Jun 29, 2022
@datho7561
Improve TemplateScanner performance
2f71b21 
Use preinitialized arrays in order to improve the scanner performance.

Addresses redhat-developer#654

Signed-off-by: David Thompson <davthomp@redhat.com>
@datho7561 datho7561 mentioned this issue Jun 29, 2022
Merged
datho7561 added a commit to datho7561/quarkus-ls that referenced this issue Jun 29, 2022
@datho7561
Improve TemplateScanner performance
48fb453 
Use preinitialized arrays in order to improve the scanner performance.

Addresses redhat-developer#654

Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561 added a commit to datho7561/quarkus-ls that referenced this issue Jun 29, 2022
@datho7561
Improve TemplateScanner performance
943fc5e 
Use preinitialized arrays in order to improve the scanner performance.

Addresses redhat-developer#654

Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561 added a commit to datho7561/quarkus-ls that referenced this issue Jun 30, 2022
@datho7561
Improve TemplateScanner performance
6cbc1a3 
Use preinitialized arrays in order to improve the scanner performance.

Addresses redhat-developer#654

Signed-off-by: David Thompson <davthomp@redhat.com>
angelozerr pushed a commit that referenced this issue Jun 30, 2022
@datho7561 @angelozerr
Improve TemplateScanner performance
9690993 
Use preinitialized arrays in order to improve the scanner performance.

Addresses #654

Signed-off-by: David Thompson <davthomp@redhat.com>
@angelozerr
Copy link
Contributor Author

All issues are fixed we can close the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@datho7561 datho7561

Labels
enhancement New feature or request performance
Projects
None yet
Milestone
v0.12.0
Development

Successfully merging a pull request may close this issue.

Delay revalidation after edit and improve cancel checking datho7561/quarkus-ls
2 participants
@angelozerr @datho7561