Delay revalidation after edit and improve cancel checking #659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angelozerr
reviewed
Jun 16, 2022
...edhat.qute.ls/src/main/java/com/redhat/qute/ls/template/TemplateFileTextDocumentService.java
Show resolved
Hide resolved
angelozerr
reviewed
Jun 16, 2022
...edhat.qute.ls/src/main/java/com/redhat/qute/ls/template/TemplateFileTextDocumentService.java
Outdated
Show resolved
Hide resolved
angelozerr
reviewed
Jun 16, 2022
...edhat.qute.ls/src/main/java/com/redhat/qute/ls/template/TemplateFileTextDocumentService.java
Outdated
Show resolved
Hide resolved
angelozerr
reviewed
Jun 16, 2022
...edhat.qute.ls/src/main/java/com/redhat/qute/ls/template/TemplateFileTextDocumentService.java
Outdated
Show resolved
Hide resolved
|
@datho7561 just for your information, the delay validation is very helpfull when you use linked editing range https://github.com/redhat-developer/vscode-quarkus/blob/master/docs/qute/TemplateSupport.md#linked-editing In this case it sends several didChange. In master branch you will have one publish diagnostic per changes (if your linked editing range update 3 object parts,y ou will have 3 validation process). With your current PR you should see just one validation process. |
datho7561
force-pushed
the
delay-revalidation
branch
from
9cf4377
to
0263011
Compare
|
@datho7561 please resolve conflicts. |
datho7561
force-pushed
the
delay-revalidation
branch
from
0263011
to
17b1a88
Compare
angelozerr
reviewed
Jun 16, 2022
qute.ls/com.redhat.qute.ls/src/main/java/com/redhat/qute/ls/commons/ModelTextDocuments.java
Outdated
Show resolved
Hide resolved
Delays revalidation of edited Qute templates to prevent excessive validation requests. Improves cancel checking in completion. Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561
force-pushed
the
delay-revalidation
branch
from
17b1a88
to
95e2b55
Compare
|
Many thanks @datho7561 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Delays revalidation of edited Qute templates to prevent excessive validation requests. Improves cancel checking in completion.
Signed-off-by: David Thompson davthomp@redhat.com