Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completion should generate only start section when empty end section is found #805

Closed
angelozerr opened this issue Feb 27, 2023 · 0 comments · Fixed by #807
Closed

Completion should generate only start section when empty end section is found #805

angelozerr opened this issue Feb 27, 2023 · 0 comments · Fixed by #807
Assignees
Labels
bug Something isn't working completion qute
Milestone

Comments

@angelozerr
Copy link
Contributor

angelozerr commented Feb 27, 2023

To support correctly surround with tag section, we need generate only start section when empty end section is found.

Given this template

{#}

completion shows for, etc, after for item apply, it generates:

{#for item in items}
  {item.name}
{/for}

Given this template which contains an empty orphan end section:

{#}
{\}

completion shows for, etc, after for item apply, it SHOULD generate:

{#for item in items}
{\}

@JessicaJHee I'm working on this issue.

@angelozerr angelozerr changed the title Update orphean end tag section when completion is applied Update orphan end tag section when completion is applied Feb 27, 2023
angelozerr pushed a commit to angelozerr/quarkus-ls that referenced this issue Feb 27, 2023
angelozerr pushed a commit to angelozerr/quarkus-ls that referenced this issue Feb 27, 2023
angelozerr pushed a commit to angelozerr/quarkus-ls that referenced this issue Feb 27, 2023
angelozerr pushed a commit to angelozerr/quarkus-ls that referenced this issue Feb 27, 2023
angelozerr pushed a commit to angelozerr/quarkus-ls that referenced this issue Feb 28, 2023
@angelozerr angelozerr changed the title Update orphan end tag section when completion is applied Show in completion only start section when empty orphan end section is found Mar 1, 2023
@angelozerr angelozerr changed the title Show in completion only start section when empty orphan end section is found Completion should generate only start section when empty orphan end section is found Mar 1, 2023
@angelozerr angelozerr changed the title Completion should generate only start section when empty orphan end section is found Completion should generate only start section when empty end section is found Mar 1, 2023
angelozerr pushed a commit to angelozerr/quarkus-ls that referenced this issue Mar 1, 2023
angelozerr pushed a commit to angelozerr/quarkus-ls that referenced this issue Mar 1, 2023
angelozerr pushed a commit to angelozerr/quarkus-ls that referenced this issue Mar 1, 2023
angelozerr pushed a commit to angelozerr/quarkus-ls that referenced this issue Mar 1, 2023
angelozerr pushed a commit to angelozerr/quarkus-ls that referenced this issue Mar 2, 2023
angelozerr pushed a commit to angelozerr/quarkus-ls that referenced this issue Mar 2, 2023
angelozerr pushed a commit to angelozerr/quarkus-ls that referenced this issue Mar 2, 2023
angelozerr pushed a commit to angelozerr/quarkus-ls that referenced this issue Mar 2, 2023
angelozerr pushed a commit to angelozerr/quarkus-ls that referenced this issue Mar 2, 2023
angelozerr pushed a commit to angelozerr/quarkus-ls that referenced this issue Mar 2, 2023
angelozerr pushed a commit to angelozerr/quarkus-ls that referenced this issue Mar 3, 2023
angelozerr pushed a commit to angelozerr/quarkus-ls that referenced this issue Mar 3, 2023
angelozerr pushed a commit to angelozerr/quarkus-ls that referenced this issue Mar 3, 2023
@datho7561 datho7561 added the bug Something isn't working label Mar 3, 2023
@datho7561 datho7561 added this to the 0.14.0 milestone Mar 3, 2023
datho7561 pushed a commit that referenced this issue Mar 3, 2023
found

Fixes #805

Signed-off-by: azerr <azerr@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment