Completion should generate only start section when empty end section is found

[angelozerr]

Generate only start section when empty end section is foundCompletion should generate only start section when empty end section is found

Fixes #805

Signed-off-by: azerr azerr@redhat.com

[angelozerr]

@JessicaJHee here a new PR which do the samething than PR #806 but without updating end tag section (since {/} is a valid end section). Here a demo:

[angelozerr]

The code of this PT should be clean, you can review it.

[datho7561]

If you have an unnamed close tag right after what you're writing, then it will never generate a close tag for tag completion, even if there aren't enough unnamed close tags to match the content you are generating:

[angelozerr]

If you have an unnamed close tag right after what you're writing, then it will never generate a close tag for tag completion, even if there aren't enough unnamed close tags to match the content you are generating:

I have improved template parser to take care of this usecase. Please retry it.

[angelozerr]

@JessicaJHee could you check if it is working with surround please.

[datho7561]

Given the following template:

|{#each items}

{#each items}
  {it.name}
{/each}

{#each items}

{#each items}
  {it.name}
{/each}



{/}|

If I select between the two |, then I get a lot of code action failure notifications

[JessicaJHee]

LGTM, works well with surround with command! Thank you for writing lots of tests :)

[angelozerr]

According this comment it is not a good idea to change the behavior of the parser.

I revert my change and to fix the original issue

{#each items}
	{#|}
{/}

which didn't generate the full content of the snippet (only the first part of the section), I check if parent section of {# is closed. In this case, #each is not closed because the {/} is linked to {#. As parent section of {# (which is the #each) is not closed, the full content of the snippet must be generated.

@datho7561 please retry it and I suggest that you get redhat-developer/vscode-quarkus#585 to play with surround too.

[angelozerr]

Here a demo:

[datho7561]

Seems pretty good so far, I'm going to try it out with redhat-developer/vscode-quarkus#585 and see how that goes...

[datho7561]

This works very well. I found a few spots where the code could be cleaned up a bit, but nothing major. Feel free to merge after you've addressed the comments.

[datho7561]

Looks good. Thanks, Angelo!