Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{if !inject:beanName}{/if} is marked as invalid #835

Merged
merged 1 commit into from
Mar 29, 2023

Conversation

angelozerr
Copy link
Contributor

{if !inject:beanName}{/if} is marked as invalid

Fixes #828

@angelozerr
Copy link
Contributor Author

This PR fixes the false validation with !

But there is a problem with completion.

{#if !| }

doesn't show inject if completion is triggered after ! .

@angelozerr
Copy link
Contributor Author

But there is a problem with completion.

It should be fixed now.

Fixes redhat-developer#828

Signed-off-by: azerr <azerr@redhat.com>
Copy link
Contributor

@datho7561 datho7561 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works okay for me, and I filed a bug to improve the corner case I ran into.

@datho7561 datho7561 merged commit 30a2d17 into redhat-developer:master Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

{if !inject:beanName}{/if} is marked as invalid
2 participants