Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

{if !inject:beanName}{/if} is marked as invalid #828

Closed
datho7561 opened this issue Mar 27, 2023 · 4 comments · Fixed by #835
Closed

{if !inject:beanName}{/if} is marked as invalid #828

datho7561 opened this issue Mar 27, 2023 · 4 comments · Fixed by #835
Assignees
@angelozerr
Labels
bug Something isn't working qute validation
Milestone
0.14.0

Comments

@datho7561
Copy link
Contributor

datho7561 commented Mar 27, 2023 •
edited
Loading

Open https://github.com/FroMage/quarkus-renarde-todo/blob/7784cba6de7f31e937726eec6725df3c95eca1f6/src/main/resources/templates/main.html#L31 in vscode-quarkus, and it will be marked with the warning "No namespace resolver found for: !inject". However, this code runs fine. It would be nice if we didn't mark it as invalid.
@datho7561 datho7561 added bug Something isn't working validation qute labels Mar 27, 2023
@fbricon
Copy link
Collaborator

fbricon commented Mar 28, 2023

is it a regression? inject: has been supported for a while

@datho7561
Copy link
Contributor Author

This doesn't appear to be a regression, I double checked against 1.13.0 from the marketplace

@angelozerr
Copy link
Contributor

It is not à regression. We need to support ! character.

Let s me investigate how to manage that. If it is easy I will create a pr

angelozerr added a commit to angelozerr/quarkus-ls that referenced this issue Mar 29, 2023
@angelozerr
{if !inject:beanName}{/if} is marked as invalid
16e0d75 
Fixes redhat-developer#828

Signed-off-by: azerr <azerr@redhat.com>
@angelozerr angelozerr mentioned this issue Mar 29, 2023
Merged
angelozerr added a commit to angelozerr/quarkus-ls that referenced this issue Mar 29, 2023
@angelozerr
{if !inject:beanName}{/if} is marked as invalid
e0874af 
Fixes redhat-developer#828

Signed-off-by: azerr <azerr@redhat.com>
@angelozerr angelozerr self-assigned this Mar 29, 2023
@angelozerr angelozerr added this to the 0.14.0 milestone Mar 29, 2023
@angelozerr
Copy link
Contributor

This issue should be fixed with #835

datho7561 pushed a commit that referenced this issue Mar 29, 2023
@angelozerr @datho7561
{if !inject:beanName}{/if} is marked as invalid
30a2d17 
Fixes #828

Signed-off-by: azerr <azerr@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@angelozerr angelozerr

Labels
bug Something isn't working qute validation
Projects
IDE Raptors
Archived in project
Milestone
0.14.0
Development

Successfully merging a pull request may close this issue.

{if !inject:beanName}{/if} is marked as invalid angelozerr/quarkus-ls
3 participants
@fbricon @angelozerr @datho7561