Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use newer JDT.LS's JavadocContentAccess2 methods #949

Merged
merged 1 commit into from
Jan 29, 2024
Merged

fix: use newer JDT.LS's JavadocContentAccess2 methods #949

merged 1 commit into from
Jan 29, 2024

Conversation

fbricon
Copy link
Collaborator

@fbricon fbricon commented Jan 26, 2024 •
edited

Fixes javadoc for qute, similar to eclipse/lsp4mp#432.

Related to redhat-developer/vscode-quarkus#638

@fbricon fbricon added the bug Something isn't working label Jan 26, 2024
@fbricon fbricon marked this pull request as draft January 26, 2024 17:57
@fbricon fbricon force-pushed the fix-javadoccontentaccess branch 6 times, most recently from 295abc6 to 390d7b0 Compare January 29, 2024 09:35
@fbricon
Copy link
Collaborator Author

fbricon commented Jan 29, 2024

Plenty of test failures like:

Errors: 
  ConfigItemIntBoolDefaultValueTest.configItemIntBoolDefaultValueTest:36->BasePropertiesManagerTest.getMicroProfileProjectInfoFromMavenProject:130 » NoSuchMethod 'void org.eclipse.jdt.internal.core.search.JavaSearchScope.add(org.eclipse.jdt.internal.core.JavaProject, int, java.util.HashSet)'
  MicroProfileConfigPropertyTest.configQuickstartFromClasspath:34->BasePropertiesManagerTest.getMicroProfileProjectInfoFromMavenProject:130 » NoSuchMethod 'void org.eclipse.jdt.internal.core.search.JavaSearchScope.add(org.eclipse.jdt.internal.core.JavaProject, int, java.util.HashSet)'
  MicroProfileConfigPropertyTest.configQuickstartFromJavaSources:114->BasePropertiesManagerTest.getMicroProfileProjectInfoFromMavenProject:130 » NoSuchMethod 'java.lang.Object org.eclipse.jdt.internal.core.JavaModelManager.getInfo(org.eclipse.jdt.core.IJavaElement)'
  PropertiesManagerClassPathKindTest.configQuickstartTest:65 » NoSuchMethod 'void org.eclipse.jdt.internal.core.search.JavaSearchScope.add(org.eclipse.jdt.internal.core.JavaProject, int, java.util.HashSet)'
  PropertiesManagerTest.quarkusCorePropertiesWithOnlyCore:57->quarkusCoreTest:73 » NoSuchMethod 'void org.eclipse.jdt.internal.core.search.JavaSearchScope.add(org.eclipse.jdt.internal.core.JavaProject, int, java.util.HashSet)'
  QuarkusConfigPropertiesTest.configPropertiesNoDefaultNamingStrategy:56 » NoSuchMethod 'void org.eclipse.jdt.internal.core.search.JavaSearchScope.add(org.eclipse.jdt.internal.core.JavaProject, int, java.util.HashSet)'
  QuarkusConfigPropertiesTest.configPropertiesVerbatimDefaultNamingStrategy:180 » NoSuchMethod 'void org.eclipse.jdt.internal.core.search.JavaSearchScope.add(org.eclipse.jdt.internal.core.JavaProject, int, java.util.HashSet)'
  QuarkusConfigRootTest.allQuarkusExtensions:67->BasePropertiesManagerTest.getMicroProfileProjectInfoFromMavenProject:123->BasePropertiesManagerTest.getMicroProfileProjectInfoFromMavenProject:130 » NoSuchMethod 'void org.eclipse.jdt.internal.core.search.JavaSearchScope.add(org.eclipse.jdt.internal.core.JavaProject, int, java.util.HashSet)'
  QuarkusConfigRootTest.configQuickStart:174->BasePropertiesManagerTest.getMicroProfileProjectInfoFromMavenProject:130 » NoSuchMethod 'void org.eclipse.jdt.internal.core.search.JavaSearchScope.add(org.eclipse.jdt.internal.core.JavaProject, int, java.util.HashSet)'
  QuarkusConfigRootTest.hibernateOrmResteasy:45->BasePropertiesManagerTest.getMicroProfileProjectInfoFromMavenProject:123->BasePropertiesManagerTest.getMicroProfileProjectInfoFromMavenProject:130 » NoSuchMethod 'void org.eclipse.jdt.internal.core.search.JavaSearchScope.add(org.eclipse.jdt.internal.core.JavaProject, int, java.util.HashSet)'
  QuarkusHibernateORMPropertyTest.quarkusContainerImages:34->BasePropertiesManagerTest.getMicroProfileProjectInfoFromMavenProject:130 » NoSuchMethod 'void org.eclipse.jdt.internal.core.search.JavaSearchScope.add(org.eclipse.jdt.internal.core.JavaProject, int, java.util.HashSet)'
  QuarkusKubernetesTest.docker:159->BasePropertiesManagerTest.getMicroProfileProjectInfoFromMavenProject:123->BasePropertiesManagerTest.getMicroProfileProjectInfoFromMavenProject:130 » NoSuchMethod 'void org.eclipse.jdt.internal.core.search.JavaSearchScope.add(org.eclipse.jdt.internal.core.JavaProject, int, java.util.HashSet)'
  QuarkusKubernetesTest.kubernetes:35->BasePropertiesManagerTest.getMicroProfileProjectInfoFromMavenProject:123->BasePropertiesManagerTest.getMicroProfileProjectInfoFromMavenProject:130 » NoSuchMethod 'void org.eclipse.jdt.internal.core.search.JavaSearchScope.add(org.eclipse.jdt.internal.core.JavaProject, int, java.util.HashSet)'
  QuarkusKubernetesTest.openshift:82->BasePropertiesManagerTest.getMicroProfileProjectInfoFromMavenProject:123->BasePropertiesManagerTest.getMicroProfileProjectInfoFromMavenProject:130 » NoSuchMethod 'void org.eclipse.jdt.internal.core.search.JavaSearchScope.add(org.eclipse.jdt.internal.core.JavaProject, int, java.util.HashSet)'
  QuarkusKubernetesTest.s2i:123->BasePropertiesManagerTest.getMicroProfileProjectInfoFromMavenProject:123->BasePropertiesManagerTest.getMicroProfileProjectInfoFromMavenProject:130 » NoSuchMethod 'void org.eclipse.jdt.internal.core.search.JavaSearchScope.add(org.eclipse.jdt.internal.core.JavaProject, int, java.util.HashSet)'
  QuarkusScheduledPropertiesTest.configQuickstartFromClasspath:29->BasePropertiesManagerTest.getMicroProfileProjectInfoFromMavenProject:130 » NoSuchMethod 'void org.eclipse.jdt.internal.core.search.JavaSearchScope.add(org.eclipse.jdt.internal.core.JavaProject, int, java.util.HashSet)'
  QuarkusScheduledPropertiesTest.configQuickstartFromJavaSources:46->BasePropertiesManagerTest.getMicroProfileProjectInfoFromMavenProject:130 » NoSuchMethod 'java.lang.Object org.eclipse.jdt.internal.core.JavaModelManager.getInfo(org.eclipse.jdt.core.IJavaElement)'
  QuarkusCachePropertiesTest.cacheQuickstartFromClasspath:35->BasePropertiesManagerTest.getMicroProfileProjectInfoFromMavenProject:130 » NoSuchMethod 'void org.eclipse.jdt.internal.core.search.JavaSearchScope.add(org.eclipse.jdt.internal.core.JavaProject, int, java.util.HashSet)'
  JavaCodeLensQuarkusRestClientTest.urlCodeLensYaml:46 » NoSuchMethod 'java.lang.Object org.eclipse.jdt.internal.core.JavaModelManager.getInfo(org.eclipse.jdt.core.IJavaElement)'
  QuarkusConfigJavaDefinitionTest.configPropertyNameDefinitionYml:57 » NoSuchMethod 'java.lang.Object org.eclipse.jdt.internal.core.JavaModelManager.getInfo(org.eclipse.jdt.core.IJavaElement)'
  QuarkusConfigJavaHoverTest.configPropertyNameRespectsPrecendence:53 » NoSuchMethod 'java.lang.Object org.eclipse.jdt.internal.core.JavaModelManager.getInfo(org.eclipse.jdt.core.IJavaElement)'
  QuarkusConfigJavaHoverTest.configPropertyNameYaml:100 » NoSuchMethod 'java.lang.Object org.eclipse.jdt.internal.core.JavaModelManager.getInfo(org.eclipse.jdt.core.IJavaElement)'
  QuarkusConfigJavaHoverTest.configPropertyNameYml:143 » NoSuchMethod 'java.lang.Object org.eclipse.jdt.internal.core.JavaModelManager.getInfo(org.eclipse.jdt.core.IJavaElement)'
  QuarkusConfigJavaHoverTest.perProfileConfigPropertyFile:185 » NoSuchMethod 'java.lang.Object org.eclipse.jdt.internal.core.JavaModelManager.getInfo(org.eclipse.jdt.core.IJavaElement)'
  QuarkusConfigMappingTest.configMapping:34->BasePropertiesManagerTest.getMicroProfileProjectInfoFromMavenProject:130 » NoSuchMethod 'java.lang.Object org.eclipse.jdt.internal.core.JavaModelManager.getInfo(org.eclipse.jdt.core.IJavaElement)'
  QuarkusContainerImagesTest.quarkusContainerImages:36->BasePropertiesManagerTest.getMicroProfileProjectInfoFromMavenProject:130 » NoSuchMethod 'void org.eclipse.jdt.internal.core.search.JavaSearchScope.add(org.eclipse.jdt.internal.core.JavaProject, int, java.util.HashSet)'
  JaxRsApplicationPathCodeLensTest.urlCodeLensProperties:53->assertCodeLenses:62 » NoSuchMethod 'java.lang.Object org.eclipse.jdt.internal.core.JavaModelManager.getInfo(org.eclipse.jdt.core.IJavaElement)'
  JaxRsCodeLensTest.urlCodeLensProperties:51->assertCodeLenses:139 » NoSuchMethod 'java.lang.Object org.eclipse.jdt.internal.core.JavaModelManager.getInfo(org.eclipse.jdt.core.IJavaElement)'
  JaxRsCodeLensTest.urlCodeLensYaml:107->assertCodeLenses:139 » NoSuchMethod 'java.lang.Object org.eclipse.jdt.internal.core.JavaModelManager.getInfo(org.eclipse.jdt.core.IJavaElement)'
  RenardeJaxRsTest.absolutePathCodeLens:67 » NoSuchMethod 'java.lang.Object org.eclipse.jdt.internal.core.JavaModelManager.getInfo(org.eclipse.jdt.core.IJavaElement)'
  RenardeJaxRsTest.codeLens:48 » NoSuchMethod 'java.lang.Object org.eclipse.jdt.internal.core.JavaModelManager.getInfo(org.eclipse.jdt.core.IJavaElement)'
  RenardeJaxRsTest.workspaceSymbols:78 » NoSuchMethod 'java.lang.Object org.eclipse.jdt.internal.core.JavaModelManager.getInfo(org.eclipse.jdt.core.IJavaElement)'
  QuarkusScheduledDefinitionTest.configCronPropertyDefinition:53 » NoSuchMethod 'java.lang.Object org.eclipse.jdt.internal.core.JavaModelManager.getInfo(org.eclipse.jdt.core.IJavaElement)'
  QuarkusScheduledDefinitionTest.configEveryPropertyNameDefinition:71 » NoSuchMethod 'java.lang.Object org.eclipse.jdt.internal.core.JavaModelManager.getInfo(org.eclipse.jdt.core.IJavaElement)'
  QuarkusScheduledDefinitionTest.configPropertyExpressionDefinition:89 » NoSuchMethod 'java.lang.Object org.eclipse.jdt.internal.core.JavaModelManager.getInfo(org.eclipse.jdt.core.IJavaElement)'
  QuarkusScheduledHoverTest.configFirstPropertyNameHover:52 » NoSuchMethod 'java.lang.Object org.eclipse.jdt.internal.core.JavaModelManager.getInfo(org.eclipse.jdt.core.IJavaElement)'
  QuarkusScheduledHoverTest.configPropertyExpressionHover:88 » NoSuchMethod 'java.lang.Object org.eclipse.jdt.internal.core.JavaModelManager.getInfo(org.eclipse.jdt.core.IJavaElement)'
  QuarkusScheduledHoverTest.configSecondPropertyNameHover:70 » NoSuchMethod 'java.lang.Object org.eclipse.jdt.internal.core.JavaModelManager.getInfo(org.eclipse.jdt.core.IJavaElement)'

Caused by 2-week old refatoring eclipse-jdt/eclipse.jdt.core@4556ac2#diff-1999f63d81fb3fd59a1d400627b6dc3eb4dab002248a599d172996e909ce007aR104

jdt.core changing method signatures by adding generics, making it binary incompatible with the lsp4mp bits compiled against previous signatures.

@fbricon
fix: use newer JDT.LS's JavadocContentAccess2 methods
7709abe 
Signed-off-by: Fred Bricon <fbricon@gmail.com>
@fbricon fbricon marked this pull request as ready for review January 29, 2024 13:41
@fbricon fbricon self-assigned this Jan 29, 2024
@fbricon fbricon added this to the 0.18.0 milestone Jan 29, 2024
@fbricon fbricon merged commit 6ea798e into redhat-developer:master Jan 29, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@fbricon fbricon

Labels
bug Something isn't working
Projects
None yet
Milestone
0.18.0
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@fbricon