fix: use newer JDT.LS's JavadocContentAccess2 methods#432
Merged
fbricon merged 1 commit intoeclipse-lsp4mp:masterfrom Jan 26, 2024
Merged
fix: use newer JDT.LS's JavadocContentAccess2 methods#432fbricon merged 1 commit intoeclipse-lsp4mp:masterfrom
fbricon merged 1 commit intoeclipse-lsp4mp:masterfrom
Conversation
fbricon
force-pushed
the
fix-javadoccontentaccess
branch
from
5063fc7 to
ffc4b09
Compare
Signed-off-by: Fred Bricon <fbricon@gmail.com>
fbricon
force-pushed
the
fix-javadoccontentaccess
branch
from
ffc4b09 to
fa61195
Compare
rgrunber
approved these changes
Jan 26, 2024
Contributor
rgrunber
left a comment
rgrunber
left a comment
There was a problem hiding this comment.
This makes lsp4mp build again so just based on that, it's the right thing to do. JavadocContentAccess2 should be accessible also in jdt.core.manpulation via. newer JDT-LS target platform.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes redhat-developer/vscode-quarkus#638
But Qute-LS will need a similar fix.
Signed-off-by: Fred Bricon fbricon@gmail.com