Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RHIDP-1493: separate plugin title for RHDH #199

Merged
merged 5 commits into from
May 9, 2024
Merged

RHIDP-1493: separate plugin title for RHDH #199

merged 5 commits into from
May 9, 2024

Conversation

hmanwani-rh
Copy link
Member

@hmanwani-rh hmanwani-rh commented Apr 26, 2024 •
edited by linfraze
Loading

@rhdh-bot
Copy link
Collaborator

PR Preview: https://redhat-developer.github.io/red-hat-developers-documentation-rhdh/pr-199/

@rhdh-bot
Copy link
Collaborator

PR Preview: https://redhat-developer.github.io/red-hat-developers-documentation-rhdh/pr-199/

linfraze
linfraze reviewed Apr 26, 2024
View reviewed changes
Copy link
Member

@linfraze linfraze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a couple suggestions for consideration

modules/rhdh-plugins-reference/con-rhdh-plugins.adoc Outdated Show resolved Hide resolved
modules/rhdh-plugins-reference/con-rhdh-plugins.adoc Outdated Show resolved Hide resolved
titles/plugin-rhdh/docinfo.xml Outdated Show resolved Hide resolved
titles/plugin-rhdh/docinfo.xml Show resolved Hide resolved
@rhdh-bot
Copy link
Collaborator

PR Preview: https://redhat-developer.github.io/red-hat-developers-documentation-rhdh/pr-199/

@rhdh-bot
Copy link
Collaborator

PR Preview: https://redhat-developer.github.io/red-hat-developers-documentation-rhdh/pr-199/

@rhdh-bot
Copy link
Collaborator

PR Preview: https://redhat-developer.github.io/red-hat-developers-documentation-rhdh/pr-199/

@hmanwani-rh
Copy link
Member Author

@davidfestal I've temporarily removed the "creating plugins in RHDH" section from the PR and transferred the content to a Google doc to include at a later stage.

davidfestal
davidfestal reviewed May 7, 2024
View reviewed changes
titles/plugin-rhdh/docinfo.xml Outdated Show resolved Hide resolved
modules/rhdh-plugins-reference/proc-create-plugin.adoc Show resolved Hide resolved
titles/plugin-rhdh/title-plugin.adoc Outdated Show resolved Hide resolved
@rhdh-bot
Copy link
Collaborator

rhdh-bot commented May 8, 2024

PR Preview: https://redhat-developer.github.io/red-hat-developers-documentation-rhdh/pr-199/

@hmanwani-rh hmanwani-rh changed the title RHIDP-1493: document how to create plugins and separate plugin title RHIDP-1493: separate plugin title for RHDH May 8, 2024
@rhdh-bot
Copy link
Collaborator

rhdh-bot commented May 8, 2024

PR Preview: https://redhat-developer.github.io/red-hat-developers-documentation-rhdh/pr-199/

@josephca josephca requested a review from gustavolira May 8, 2024 16:12
Gerry-Forde
Gerry-Forde approved these changes May 9, 2024
View reviewed changes
Copy link
Member

@Gerry-Forde Gerry-Forde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hmanwani-rh hmanwani-rh merged commit fceddf5 into redhat-developer:main May 9, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidfestal davidfestal davidfestal left review comments

@linfraze linfraze linfraze left review comments

@gustavolira gustavolira gustavolira approved these changes

@Gerry-Forde Gerry-Forde Gerry-Forde approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@hmanwani-rh @rhdh-bot @davidfestal @gustavolira @linfraze @Gerry-Forde