Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RHIDP-1908: Documenting the telemetry feature in admin guide #212

Merged
merged 18 commits into from
May 30, 2024
Merged

RHIDP-1908: Documenting the telemetry feature in admin guide #212

merged 18 commits into from
May 30, 2024

Conversation

shipsing
Copy link
Contributor

@shipsing shipsing commented May 3, 2024 •
edited by nickboldt

@rhdh-bot
Copy link
Collaborator

rhdh-bot commented May 3, 2024

PR Preview: https://redhat-developer.github.io/red-hat-developers-documentation-rhdh/pr-212/

@rhdh-bot
Copy link
Collaborator

rhdh-bot commented May 6, 2024

PR Preview: https://redhat-developer.github.io/red-hat-developers-documentation-rhdh/pr-212/

linfraze
linfraze reviewed May 6, 2024
View reviewed changes
Copy link
Member

@linfraze linfraze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replaced company name with the new attribute value

admin/assembly-rhdh-telemetry.adoc Outdated Show resolved Hide resolved
admin/assembly-rhdh-telemetry.adoc Outdated Show resolved Hide resolved
admin/proc-customizing-telemetry-destination.adoc Outdated Show resolved Hide resolved
@rhdh-bot
Copy link
Collaborator

rhdh-bot commented May 7, 2024

PR Preview: https://redhat-developer.github.io/red-hat-developers-documentation-rhdh/pr-212/

@rhdh-bot
Copy link
Collaborator

rhdh-bot commented May 7, 2024

PR Preview: https://redhat-developer.github.io/red-hat-developers-documentation-rhdh/pr-212/

kim-tsao
kim-tsao reviewed May 9, 2024
View reviewed changes
admin/assembly-rhdh-telemetry.adoc Outdated Show resolved Hide resolved
admin/assembly-rhdh-telemetry.adoc Outdated Show resolved Hide resolved
admin/assembly-rhdh-telemetry.adoc Outdated Show resolved Hide resolved
admin/assembly-rhdh-telemetry.adoc Outdated Show resolved Hide resolved
admin/proc-enabling-telemetry.adoc Outdated Show resolved Hide resolved
admin/proc-customizing-telemetry-destination.adoc Outdated Show resolved Hide resolved
admin/proc-customizing-telemetry-destination.adoc Outdated Show resolved Hide resolved
admin/proc-customizing-telemetry-destination.adoc Outdated Show resolved Hide resolved
admin/proc-customizing-telemetry-destination.adoc Outdated Show resolved Hide resolved
@rhdh-bot
Copy link
Collaborator

PR Preview: https://redhat-developer.github.io/red-hat-developers-documentation-rhdh/pr-212/

@rhdh-bot
Copy link
Collaborator

PR Preview: https://redhat-developer.github.io/red-hat-developers-documentation-rhdh/pr-212/

@rhdh-bot
Copy link
Collaborator

PR Preview: https://redhat-developer.github.io/red-hat-developers-documentation-rhdh/pr-212/

@rhdh-bot
Copy link
Collaborator

PR Preview: https://redhat-developer.github.io/red-hat-developers-documentation-rhdh/pr-212/

@zdrapela zdrapela self-requested a review May 14, 2024 07:43
zdrapela
zdrapela approved these changes May 14, 2024
View reviewed changes
Copy link
Contributor

@zdrapela zdrapela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍️
Thanks!

@kadel
Copy link
Member

kadel commented May 14, 2024

/hold
We can't merge this just yet; we are still figuring out some details with the legal team.

kim-tsao
kim-tsao reviewed May 14, 2024
View reviewed changes
admin/assembly-rhdh-telemetry.adoc Outdated Show resolved Hide resolved
admin/assembly-rhdh-telemetry.adoc Outdated Show resolved Hide resolved
admin/proc-customizing-telemetry-segment.adoc Outdated Show resolved Hide resolved
@rhdh-bot
Copy link
Collaborator

PR Preview: https://redhat-developer.github.io/red-hat-developers-documentation-rhdh/pr-212/

kadel
kadel requested changes May 15, 2024
View reviewed changes
admin/assembly-rhdh-telemetry.adoc Outdated Show resolved Hide resolved
admin/assembly-rhdh-telemetry.adoc Outdated Show resolved Hide resolved
admin/assembly-rhdh-telemetry.adoc Outdated Show resolved Hide resolved
admin/assembly-rhdh-telemetry.adoc Outdated Show resolved Hide resolved
admin/assembly-rhdh-telemetry.adoc Outdated Show resolved Hide resolved
admin/proc-disabling-telemetry-in-CI-environment.adoc Outdated Show resolved Hide resolved
admin/proc-enabling-telemetry.adoc Outdated Show resolved Hide resolved
admin/proc-disabling-telemetry.adoc Outdated Show resolved Hide resolved
admin/proc-disabling-telemetry.adoc Outdated Show resolved Hide resolved
admin/assembly-rhdh-telemetry.adoc Outdated Show resolved Hide resolved
@rhdh-bot
Copy link
Collaborator

PR Preview: https://redhat-developer.github.io/red-hat-developers-documentation-rhdh/pr-212/

nickboldt
nickboldt requested changes May 27, 2024
View reviewed changes
Copy link
Member

@nickboldt nickboldt left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setting this to blocked because we don't have DOCUMENTED approval from Legal to enable an opt-out telemetry feature.

If we change the code (and therefore the doc) to opt-in (disabled by default) then I'm otherwise happy with this PR.

@nickboldt nickboldt mentioned this pull request May 28, 2024
Closed
5 tasks
@nickboldt nickboldt self-requested a review May 28, 2024 16:45
@openshift-ci openshift-ci bot removed the lgtm label May 28, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented May 28, 2024

New changes are detected. LGTM label has been removed.

nickboldt
nickboldt previously approved these changes May 28, 2024
View reviewed changes
@rhdh-bot
Copy link
Collaborator

PR Preview: https://redhat-developer.github.io/red-hat-developers-documentation-rhdh/pr-212/

@nickboldt nickboldt enabled auto-merge (squash) May 28, 2024 16:46
@nickboldt
Update assemblies/assembly-rhdh-telemetry.adoc
d69079d 
switching back to on-by-default despite vigorous protests that this is a BAD IDEA and that we don't have proper approvals.
@rhdh-bot
Copy link
Collaborator

PR Preview: https://redhat-developer.github.io/red-hat-developers-documentation-rhdh/pr-212/

@kadel
Copy link
Member

kadel commented May 30, 2024

We can go ahead and merge this. Just to confirm, we are going with enabled by default (opt-out) more information in https://issues.redhat.com/browse/RHIDP-1311 and the related parent feature

@rhdh-bot
Copy link
Collaborator

PR Preview: https://redhat-developer.github.io/red-hat-developers-documentation-rhdh/pr-212/

@nickboldt nickboldt disabled auto-merge May 30, 2024 13:35
@nickboldt nickboldt merged commit 2ef0e20 into redhat-developer:main May 30, 2024
2 checks passed
@nickboldt
Copy link
Member

Merging as we have approvals from at least a few people.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickboldt nickboldt nickboldt left review comments

@zdrapela zdrapela zdrapela approved these changes

@kadel kadel kadel left review comments

@kim-tsao kim-tsao Awaiting requested review from kim-tsao

@linfraze linfraze Awaiting requested review from linfraze

@abrennan89 abrennan89 Awaiting requested review from abrennan89

Assignees

@kadel kadel

Labels
do-not-merge/hold
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@shipsing @rhdh-bot @kadel @nickboldt @abrennan89 @linfraze @zdrapela @kim-tsao