RHIDP-2384: Clean-up Configuring the RHDH CR section & sub-sections #232

linfraze · 2024-05-20T19:36:08Z

Description:

Deletes the Configuring the RHDH CR section
Improves the Adding a custom application configuration file to OCP section
Specifies which procedure is for the Operator and which is for the Helm chart
Adds both the Adding a custom application configuration file to OCP using the Operator and Adding a custom application configuration file to OCP using the Helm chart to both the Admin and Getting Started guides using single sourcing best practices

Versions:
1.1+

Jira link:
https://issues.redhat.com/browse/RHIDP-2384

Preview link:
Admin guide 2.1.1 & 2.2.1

Getting Started guide 3.1.1 & 3.1.2

Reviews:
SME: @rm3l
QE: @gustavolira
Peer review: @abrennan89

rhdh-bot · 2024-05-20T19:57:13Z

PR Preview: https://redhat-developer.github.io/red-hat-developers-documentation-rhdh/pr-232/

rhdh-bot · 2024-05-21T17:18:24Z

PR Preview: https://redhat-developer.github.io/red-hat-developers-documentation-rhdh/pr-232/

rhdh-bot · 2024-05-21T17:25:30Z

PR Preview: https://redhat-developer.github.io/red-hat-developers-documentation-rhdh/pr-232/

rhdh-bot · 2024-05-21T17:41:14Z

PR Preview: https://redhat-developer.github.io/red-hat-developers-documentation-rhdh/pr-232/

modules/installation/proc-config-rhdh-custom-resource.adoc

rhdh-bot · 2024-05-21T17:46:14Z

PR Preview: https://redhat-developer.github.io/red-hat-developers-documentation-rhdh/pr-232/

rm3l

A few comments.

modules/installation/proc-config-rhdh-custom-resource.adoc

rhdh-bot · 2024-05-23T19:55:07Z

PR Preview: https://redhat-developer.github.io/red-hat-developers-documentation-rhdh/pr-232/

rhdh-bot · 2024-05-30T21:11:17Z

PR Preview: https://redhat-developer.github.io/red-hat-developers-documentation-rhdh/pr-232/

rm3l

A few comments, but overall this is much better. Thanks @linfraze !!

modules/installation/proc-add-custom-app-config-file-ocp-operator.adoc

modules/installation/proc-install-rhdh-ocp-operator.adoc

rhdh-bot · 2024-05-31T19:52:19Z

PR Preview: https://redhat-developer.github.io/red-hat-developers-documentation-rhdh/pr-232/

rh-pre-commit.version: 2.2.0 rh-pre-commit.check-secrets: ENABLED

rhdh-bot · 2024-06-04T14:17:15Z

PR Preview: https://redhat-developer.github.io/red-hat-developers-documentation-rhdh/pr-232/

modules/installation/proc-add-custom-app-config-file-ocp-operator.adoc

modules/installation/proc-install-rhdh-ocp-operator.adoc

abrennan89 · 2024-06-04T15:33:19Z

FYI, just a tip in case you're not aware @linfraze - if you squash your commits before you merge this, it will make your life easier if you need to do a manual cherrypick, since you'll only need to CP one commit 🙏🏻

Co-authored-by: Armel Soro <armel@rm3l.org> rh-pre-commit.version: 2.2.0 rh-pre-commit.check-secrets: ENABLED

rhdh-bot · 2024-06-04T16:44:52Z

PR Preview: https://redhat-developer.github.io/red-hat-developers-documentation-rhdh/pr-232/

abrennan89

One last minor formatting thing, otherwise lgtm, great work!

modules/installation/proc-add-custom-app-config-file-ocp-operator.adoc

rhdh-bot · 2024-06-04T18:31:11Z

PR Preview: https://redhat-developer.github.io/red-hat-developers-documentation-rhdh/pr-232/

…tor.adoc Co-authored-by: Ashleigh Brennan <abrennan@redhat.com>

rhdh-bot · 2024-06-04T18:32:24Z

PR Preview: https://redhat-developer.github.io/red-hat-developers-documentation-rhdh/pr-232/

linfraze · 2024-06-04T18:43:56Z

/cherry-pick 1.2.x

openshift-cherrypick-robot · 2024-06-04T18:44:35Z

@linfraze: new pull request created: #255

In response to this:

/cherry-pick 1.2.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

abrennan89 · 2024-06-04T20:53:08Z

@linfraze does this need to be cherrypicked to 1.1 also?

linfraze temporarily deployed to external May 20, 2024 19:36 — with GitHub Actions Inactive

This comment was marked as outdated.

Sign in to view

linfraze force-pushed the RHIDP-2384 branch from b39a69d to f7a87cf Compare May 20, 2024 19:52

linfraze temporarily deployed to external May 20, 2024 19:52 — with GitHub Actions Inactive

This comment was marked as outdated.

Sign in to view

linfraze force-pushed the RHIDP-2384 branch from f7a87cf to 420119b Compare May 20, 2024 19:56

linfraze temporarily deployed to external May 20, 2024 19:56 — with GitHub Actions Inactive

linfraze force-pushed the RHIDP-2384 branch from 420119b to 7540ca7 Compare May 21, 2024 17:17

linfraze temporarily deployed to external May 21, 2024 17:17 — with GitHub Actions Inactive

linfraze requested a review from rm3l May 21, 2024 17:18

linfraze temporarily deployed to external May 21, 2024 17:24 — with GitHub Actions Inactive

linfraze force-pushed the RHIDP-2384 branch from 1568d8b to 4305398 Compare May 21, 2024 17:39

linfraze temporarily deployed to external May 21, 2024 17:40 — with GitHub Actions Inactive

linfraze commented May 21, 2024

View reviewed changes

modules/installation/proc-config-rhdh-custom-resource.adoc Outdated Show resolved Hide resolved

linfraze force-pushed the RHIDP-2384 branch from 4305398 to 5f82935 Compare May 21, 2024 17:45

linfraze temporarily deployed to external May 21, 2024 17:45 — with GitHub Actions Inactive

rm3l reviewed May 22, 2024

View reviewed changes

linfraze force-pushed the RHIDP-2384 branch from 5f82935 to 8d2ca4b Compare May 23, 2024 19:54

linfraze temporarily deployed to external May 23, 2024 19:54 — with GitHub Actions Inactive

linfraze force-pushed the RHIDP-2384 branch from 8d2ca4b to 71ed979 Compare May 30, 2024 21:10

linfraze temporarily deployed to external May 30, 2024 21:10 — with GitHub Actions Inactive

linfraze changed the title ~~RHIDP-2384: Move procedural steps to Configuring the RHDH CR section~~ RHIDP-2384: Clean-up Configuring the RHDH CR section & sub-sections May 30, 2024

rm3l reviewed May 31, 2024

View reviewed changes

rm3l approved these changes May 31, 2024

View reviewed changes

gustavolira approved these changes Jun 2, 2024

View reviewed changes

linfraze added 5 commits June 4, 2024 10:15

RHIDP-2384: Move procedural steps to Configuring the RHDH CR section

3551f92

rh-pre-commit.version: 2.2.0 rh-pre-commit.check-secrets: ENABLED

RHIDP-2384: Apply SME feedback

ff0fed0

RHIDP-2484 sub-task: Remove Configuring RHDH CR content

314483e

rh-pre-commit.version: 2.2.0 rh-pre-commit.check-secrets: ENABLED

Rename file to specify that it is for the Operator

bcc155f

rh-pre-commit.version: 2.2.0 rh-pre-commit.check-secrets: ENABLED

xref clean-up

98291f2

rh-pre-commit.version: 2.2.0 rh-pre-commit.check-secrets: ENABLED

linfraze force-pushed the RHIDP-2384 branch from 087615b to 96ea177 Compare June 4, 2024 14:16

linfraze temporarily deployed to external June 4, 2024 14:16 — with GitHub Actions Inactive

abrennan89 reviewed Jun 4, 2024

View reviewed changes

Apply suggestions from code review

0e7cd79

Co-authored-by: Armel Soro <armel@rm3l.org> rh-pre-commit.version: 2.2.0 rh-pre-commit.check-secrets: ENABLED

linfraze force-pushed the RHIDP-2384 branch from 96ea177 to 0e7cd79 Compare June 4, 2024 16:44

linfraze temporarily deployed to external June 4, 2024 16:44 — with GitHub Actions Inactive

abrennan89 previously approved these changes Jun 4, 2024

View reviewed changes

modules/installation/proc-add-custom-app-config-file-ocp-operator.adoc Outdated Show resolved Hide resolved

Merge branch 'main' into RHIDP-2384

9e7faa9

linfraze temporarily deployed to external June 4, 2024 18:30 — with GitHub Actions Inactive

Update modules/installation/proc-add-custom-app-config-file-ocp-opera…

cc38e4f

…tor.adoc Co-authored-by: Ashleigh Brennan <abrennan@redhat.com>

linfraze dismissed abrennan89’s stale review via cc38e4f June 4, 2024 18:31

linfraze temporarily deployed to external June 4, 2024 18:31 — with GitHub Actions Inactive

linfraze merged commit adec432 into redhat-developer:main Jun 4, 2024
2 checks passed

openshift-cherrypick-robot mentioned this pull request Jun 4, 2024

[1.2.x] RHIDP-2384: Clean-up Configuring the RHDH CR section & sub-sections #255

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

RHIDP-2384: Clean-up Configuring the RHDH CR section & sub-sections #232

RHIDP-2384: Clean-up Configuring the RHDH CR section & sub-sections #232

linfraze commented May 20, 2024 •

edited

This comment was marked as outdated.

This comment was marked as outdated.

rhdh-bot commented May 20, 2024

rhdh-bot commented May 21, 2024

rhdh-bot commented May 21, 2024

rhdh-bot commented May 21, 2024

rhdh-bot commented May 21, 2024

rm3l left a comment

rhdh-bot commented May 23, 2024

rhdh-bot commented May 30, 2024

rm3l left a comment

rhdh-bot commented May 31, 2024

rhdh-bot commented Jun 4, 2024

abrennan89 commented Jun 4, 2024

rhdh-bot commented Jun 4, 2024

abrennan89 left a comment

rhdh-bot commented Jun 4, 2024

rhdh-bot commented Jun 4, 2024

linfraze commented Jun 4, 2024

openshift-cherrypick-robot commented Jun 4, 2024

abrennan89 commented Jun 4, 2024

RHIDP-2384: Clean-up Configuring the RHDH CR section & sub-sections #232

RHIDP-2384: Clean-up Configuring the RHDH CR section & sub-sections #232

Conversation

linfraze commented May 20, 2024 • edited

This comment was marked as outdated.

This comment was marked as outdated.

rhdh-bot commented May 20, 2024

rhdh-bot commented May 21, 2024

rhdh-bot commented May 21, 2024

rhdh-bot commented May 21, 2024

rhdh-bot commented May 21, 2024

rm3l left a comment

Choose a reason for hiding this comment

rhdh-bot commented May 23, 2024

rhdh-bot commented May 30, 2024

rm3l left a comment

Choose a reason for hiding this comment

rhdh-bot commented May 31, 2024

rhdh-bot commented Jun 4, 2024

abrennan89 commented Jun 4, 2024

rhdh-bot commented Jun 4, 2024

abrennan89 left a comment

Choose a reason for hiding this comment

rhdh-bot commented Jun 4, 2024

rhdh-bot commented Jun 4, 2024

linfraze commented Jun 4, 2024

openshift-cherrypick-robot commented Jun 4, 2024

abrennan89 commented Jun 4, 2024

linfraze commented May 20, 2024 •

edited