This repository has been archived by the owner on Mar 17, 2021. It is now read-only.
Switched che_version extraction from static master to the source branch #1700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Katka92
approved these changes
Nov 18, 2019
@ScrewTSW PR check [build 1969] failed.Depending on failure reason, the artifacts or deployment may not be present. |
ScrewTSW
force-pushed
the
hotfix-fix-prcheck-deploy-logic
branch
from
ff864e3
to
970856f
Compare
@ScrewTSW PR check [build 1970] failed.Depending on failure reason, the artifacts or deployment may not be present. |
ScrewTSW
force-pushed
the
hotfix-fix-prcheck-deploy-logic
branch
from
970856f
to
80e3af4
Compare
@ScrewTSW RH-Che [build 1971] has been successfully deployed and tested.deployment: http://rhche-prcheck-1700.devtools-dev.ext.devshift.net |
ibuziuk
reviewed
Nov 18, 2019
| @@ -37,7 +37,7 @@ echo "Installing all dependencies lasted $instal_dep_duration seconds." | |||
|
|
|||
| export PROJECT_NAMESPACE=prcheck-${RH_PULL_REQUEST_ID} | |||
| export DOCKER_IMAGE_TAG="${RH_TAG_DIST_SUFFIX}"-"${RH_PULL_REQUEST_ID}" | |||
| CHE_VERSION=$(curl -s https://raw.githubusercontent.com/redhat-developer/rh-che/master/pom.xml | xq -r '.project.parent.version') | |||
| CHE_VERSION=$(getVersionFromPom) | |||
There was a problem hiding this comment.
how does getVersionFromPom work?
There was a problem hiding this comment.
the method is being sourced from .ci/functional_tests_util.sh
it's calling
scl enable rh-maven33 "mvn -Dorg.slf4j.simpleLogger.log.org.apache.maven.cli.transfer.Slf4jMavenTransferListener=warn org.apache.maven.plugins:maven-help-plugin:evaluate -q -Dexpression=project.parent.version -DforceStdout"
to get the version from the pom in the currently checked out branch of the project.
There was a problem hiding this comment.
If yq is installed, then xq -r '.project.parent.version' pom.xml could be a replacement as well.
ibuziuk
approved these changes
Nov 18, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Changed logic for extracting Che version to use the source branch of the PR instead of the master when running prcheck script
What issues does this PR fix or reference?
hotfix - deploying incorrect version of registries for prcheck
How have you tested this PR?
manual testing