Skip to content
This repository has been archived by the owner on Mar 17, 2021. It is now read-only.

Revert "Skip functional test in CI because they are broken" #182

Closed
wants to merge 2 commits into from

Conversation

mlabuda
Copy link
Contributor

@mlabuda mlabuda commented Jul 10, 2017

Reverts #171, tests now should run successfuly

@mlabuda mlabuda requested a review from l0rd July 10, 2017 08:36
@l0rd
Copy link
Contributor

l0rd commented Jul 10, 2017

Let's merge that when che-starter is updated in prodution (c.f. openshiftio/saas#256)

@ibuziuk
Copy link
Member

ibuziuk commented Jul 10, 2017

@l0rd @mlabuda che-starter has been updated on prod, I think we are good to merge

@l0rd
Copy link
Contributor

l0rd commented Jul 10, 2017

@mlabuda another thing I would like to make sure before merging this PR is that, if the functional tests fail, we (the Che team) need to be able to access the following logs:

  • openshift events
  • che-server
  • wsagent
  • bayesian

Not having access to those logs would make almost impossible to understand what is wrong and address the failure.

@ibuziuk
Copy link
Member

ibuziuk commented Oct 3, 2017

@rhopp @Katka92 any updates on this issue ? Is it planned to include verification [1] step before pushing images ?

[1] https://github.com/redhat-developer/rh-che/blob/master/.ci/cico_deploy.sh#L32

@rhopp
Copy link
Collaborator

rhopp commented Oct 3, 2017

3 of last ~30 runs failed [1]. Every one of them with different error/failure. We need to investigate those before we can include the verification step before pushing images.

[1] - https://ci.centos.org/view/Devtools/job/devtools-che-functional-tests-periodical/

@ibuziuk
Copy link
Member

ibuziuk commented Oct 4, 2017

@rhopp thanks for clarifications. Please, let us know if some action is required from dev side. It would be really great to enable verification step in the short run

@rhopp
Copy link
Collaborator

rhopp commented Jan 22, 2018

I've created issue here: redhat-developer/che-functional-tests#139
Closing this PR as I will be providing another PR.

@rhopp rhopp closed this Jan 22, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants